[rust, bazel] separate mdbook into its own crate index #25797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnrt
reviewed
Jan 7, 2025
|
A Cargo manifest makes it slightly easier to precisely track and pin dependencies, as there're more tools (e.g. cargo-audit or cargo-deny) that handles Cargo.lock compared to Bazel lock. |
mdbook is only used as binary and we don't use it as a library, so making it a separate crate index. This allows us to avoid mixing its dependencies with other OT dependencies. Signed-off-by: Gary Guo <[email protected]>
jwnrt
approved these changes
Jan 8, 2025
It appears that `bazel mod deps` is needed when bzlmod is modified. Signed-off-by: Gary Guo <[email protected]>
|
@nbdd0121 is this okay to merge? I'd like the lockfile changes for another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mdbook is only used as binary and we don't use it as a library, so making it a separate crate index. This allows us to avoid mixing its dependencies with other OT dependencies.