Updated bazel target to include silicon test #25765
Conversation
There was a problem hiding this comment.
@rprakas-gsc, thanks for the PR.
Could you please edit the commit message in order to make the "Signed-off" line the last one? This will be consistent with all the commits in the repo.
sw/device/tests/BUILD
Outdated
| { | ||
| "//hw/top_earlgrey:sim_verilator": None, | ||
| "//hw/top_earlgrey:fpga_cw340_sival": None, | ||
| "//hw/top_earlgrey:silicon_creator": None, |
There was a problem hiding this comment.
I think that his exec_env is only meant to be used by the ROM_EXT and some manufacture tests.
@timothytrippel can you please confirm?
There was a problem hiding this comment.
@engdoreis Thanks for the comments. Made the changes to the commit message!
There was a problem hiding this comment.
Just following up on this! @timothytrippel - can you please respond to Douglas question? Thanks!
There was a problem hiding this comment.
Please use //hw/top_earlgrey:silicon_owner_sival_rom_ext. This should also be covered by EARLGREY_SILICON_OWNER_ROM_EXT_ENVS. Having this option is preferred as it will allow you to run the tests with additional SKUs (i.e. other than sival). You can search in the build file for examples on how to integrate this into your build target.
There was a problem hiding this comment.
Since you have EARLGREY_SILICON_OWNER_ROM_EXT_ENVS in, you can now remove "//hw/top_earlgrey:silicon_creator" from the list. Thanks!
There was a problem hiding this comment.
Thanks @moidx . Updated the BUILD File with the changes
rprakas-gsc
force-pushed
the
earlgrey_1.0.0
branch
from
e2f8167 to
a7214ba
Compare
Updated bazel target to include silicon tests for aes_interrupt_encryption tests Signed-off-by: Ramesh Prakash <[email protected]>
rprakas-gsc
force-pushed
the
earlgrey_1.0.0
branch
from
a7214ba to
925da8e
Compare
|
Successfully created backport PR for |
Signed-off-by: Ramesh Prakash [email protected]
Updated bazel target to include silicon tests for aes_interrupt_encryption tests