[signing] Support SPX signing with hsmtool
#25702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moidx
approved these changes
Dec 18, 2024
jadephilipoom
approved these changes
Dec 19, 2024
1. Enhance the signing rules to use the spx signing commands added to
hsmtool.
2. Change the PKCS#11 provider from sc-hsm-embedded to opensc.
- sc-hsm-embedded supports RSA3072 and ECDSA P256 signatures, but does
not support CKO_DATA objects.
- opensc supports ECDSA P256 signatures and CKO_DATA objects, but does
not support RSA3072 signatures.
We no longer use RSA3072 signatures for signing code; we _can_ use
CKO_DATA objects to hold SPX keys for signing.
Signed-off-by: Chris Frantz <[email protected]>
1. Use the formal NIST names for SPHINCS+ algorithms when saving or serializing keys. Accept the older names as aliases. - SLA-DSA-SHAKE-128s - SLA-DSA-SHA2-128s Signed-off-by: Chris Frantz <[email protected]>
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the signing rules to use the spx signing commands added to hsmtool.
Change the PKCS#11 provider from sc-hsm-embedded to opensc.
We no longer use RSA3072 signatures for signing code; we can use
CKO_DATA objects to hold SPX keys for signing.
Use the formal NIST names for SPHINCS+ algorithms when saving or serializing keys. Accept the older names as aliases.