Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[multitop_dev] Reinstate all_files and remove files from opentitan_{ip,top} #25375

Draft
wants to merge 110 commits into
base: multitop_dev
Choose a base branch
from
Draft

[multitop_dev] Reinstate all_files and remove files from opentitan_{ip,top} #25375

wants to merge 110 commits into from

Conversation

pamaury
Copy link
Contributor

@pamaury pamaury commented Nov 25, 2024

No description provided.

pamaury added 30 commits November 22, 2024 15:55
@pamaury
[bazel] Add new rules to describe hardware IP and tops
e80ed0e 
Those rules are essentially glorified filegroups that keep track
of the various types of files that make up an IP/top: hsjon, RTL
and doc. Finer-grained groups could be added in the future, e.g.
distinguish DV from RTL, add testplans, etc

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[bazel,top_earlgrey] Use new rules to describe the top
12bd23a 
Use an empty list of IPs for now. The IP rewriting script
expects to find this field to add IPs to the list.

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[bazel,autogen] Create new rule to generate C/rust headers from top
cb651fc 
The new rule takes an input a target created by opentitan_top
and will eventually replace the old one that directly used an
hjson file.

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[bazel,top] Create a new //hw/top package
33ab3cd 
This package will eventually contain top-related artefacts derived
from the top description: headers, linker files, multi-top, etc
Currently, it only contains a single item //hw/top:top that points
to //hw/top_earlgrey:top_earlgrey

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[bazel,top] Add generated C/rust rules for all IP
48f9fd4 
For now the list of IPs is empty but the infrastructure is there.
The IP rewrite except a list of IPs to add new ones.

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[otp_ctrl] Export file from BUILD file
0848f42 
This file should be exported because it is used in rules/otp.bzl
The only reason why it worked because is that the "all_files"
filegroup in otp_ctrl/data captures that files

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[sw/device] Remove explicit path to register header files
462ada3 
Register headers always the use "<name>.h" include path to avoid
depending on where the rule that creates them is located at. For
some reason, some files were using an explicit path.

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[mbx] Fix unittest
9a37958 
Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[bazel,flash_ctrl] Use new rules to describe IP
e3cd5e0 
Update template, replace all old targets with the new ones,
regenerate top.

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[bazel,clkmgr] Use new rules to describe IP
a2a39a7 
Update template, replace all old targets with the new ones,
regenerate top.

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[bazel,rstmgr] Use new rules to describe IP
0b6950f 
Update template, replace all old targets with the new ones,
regenerate top.

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[bazel,pwrmgr] Use new rules to describe IP
04adb3f 
Update template, replace all old targets with the new ones,
regenerate top.

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[bazel,rv_plic] Use new rules to describe IP
70c52cb 
Update template, replace all old targets with the new ones,
regenerate top.

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[bazel,alert_handler] Use new rules to describe IP
78c36a3 
Update template, replace all old targets with the new ones,
regenerate top.

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[bazel,pinmux] Use new rules to describe IP
05e80bb 
Replace old targets with the new ones.

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[util] Add script to convert IPs to the new rules
57cab42 
Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[bazel,adc_ctrl] Use new rules to describe IP
5d69b6d 
This commit was generated by running
/home/pamaury/project/opentitan/util/rewrite_hw.py -v -g --root /home/pamaury/project/opentitan --hjson hw/ip/adc_ctrl/data/adc_ctrl.hjson --top hw/top_earlgrey hw/ip/adc_ctrl

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[bazel,aes] Use new rules to describe IP
305576a 
This commit was generated by running
/home/pamaury/project/opentitan/util/rewrite_hw.py -v -g --root /home/pamaury/project/opentitan --hjson hw/ip/aes/data/aes.hjson --top hw/top_earlgrey hw/ip/aes

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[bazel,aon_timer] Use new rules to describe IP
0af3e85 
This commit was generated by running
/home/pamaury/project/opentitan/util/rewrite_hw.py -v -g --root /home/pamaury/project/opentitan --hjson hw/ip/aon_timer/data/aon_timer.hjson --top hw/top_earlgrey hw/ip/aon_timer

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[bazel,csrng] Use new rules to describe IP
510320b 
This commit was generated by running
/home/pamaury/project/opentitan/util/rewrite_hw.py -v -g --root /home/pamaury/project/opentitan --hjson hw/ip/csrng/data/csrng.hjson --top hw/top_earlgrey hw/ip/csrng

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[bazel,edn] Use new rules to describe IP
55a6544 
This commit was generated by running
/home/pamaury/project/opentitan/util/rewrite_hw.py -v -g --root /home/pamaury/project/opentitan --hjson hw/ip/edn/data/edn.hjson --top hw/top_earlgrey hw/ip/edn

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[bazel,entropy_src] Use new rules to describe IP
9912228 
This commit was generated by running
/home/pamaury/project/opentitan/util/rewrite_hw.py -v -g --root /home/pamaury/project/opentitan --hjson hw/ip/entropy_src/data/entropy_src.hjson --top hw/top_earlgrey hw/ip/entropy_src

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[bazel,gpio] Use new rules to describe IP
9224800 
This commit was generated by running
/home/pamaury/project/opentitan/util/rewrite_hw.py -v -g --root /home/pamaury/project/opentitan --hjson hw/ip/gpio/data/gpio.hjson --top hw/top_earlgrey hw/ip/gpio

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[bazel,hmac] Use new rules to describe IP
622f588 
This commit was generated by running
/home/pamaury/project/opentitan/util/rewrite_hw.py -v -g --root /home/pamaury/project/opentitan --hjson hw/ip/hmac/data/hmac.hjson --top hw/top_earlgrey hw/ip/hmac

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[bazel,i2c] Use new rules to describe IP
4c92e8f 
This commit was generated by running
/home/pamaury/project/opentitan/util/rewrite_hw.py -v -g --root /home/pamaury/project/opentitan --hjson hw/ip/i2c/data/i2c.hjson --top hw/top_earlgrey hw/ip/i2c

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[bazel,keymgr] Use new rules to describe IP
bcbb884 
This commit was generated by running
/home/pamaury/project/opentitan/util/rewrite_hw.py -v -g --root /home/pamaury/project/opentitan --hjson hw/ip/keymgr/data/keymgr.hjson --top hw/top_earlgrey hw/ip/keymgr

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[bazel,kmac] Use new rules to describe IP
4169149 
This commit was generated by running
/home/pamaury/project/opentitan/util/rewrite_hw.py -v -g --root /home/pamaury/project/opentitan --hjson hw/ip/kmac/data/kmac.hjson --top hw/top_earlgrey hw/ip/kmac

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[bazel,lc_ctrl] Use new rules to describe IP
c2a0e46 
This commit was generated by running
/home/pamaury/project/opentitan/util/rewrite_hw.py -v -g --root /home/pamaury/project/opentitan --hjson hw/ip/lc_ctrl/data/lc_ctrl.hjson --top hw/top_earlgrey hw/ip/lc_ctrl

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[bazel,otbn] Use new rules to describe IP
c8e6d39 
This commit was generated by running
/home/pamaury/project/opentitan/util/rewrite_hw.py -v -g --root /home/pamaury/project/opentitan --hjson hw/ip/otbn/data/otbn.hjson --top hw/top_earlgrey --keep-all-files hw/ip/otbn

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[bazel,otp_ctrl] Use new rules to describe IP
b9dddcc 
This commit was generated by running
/home/pamaury/project/opentitan/util/rewrite_hw.py -v -g --root /home/pamaury/project/opentitan --hjson hw/ip/otp_ctrl/data/otp_ctrl.hjson --top hw/top_earlgrey hw/ip/otp_ctrl

Signed-off-by: Amaury Pouly <[email protected]>
pamaury added 29 commits November 22, 2024 16:01
@pamaury
[rules] Add new rule to generate the testutils
af15bdc 
This rules runs util/autogen_testutils.py

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[isr_testutils] Replace generated files by bazel rules
ef0f1aa 
Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[isr_testutils] Remove now useless checked-in files
3508149 
Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[isr_testutils] Rewrite dependencies
2d6eacb 
Some dependencies depend on the top. For now manually select the right
ones.

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[util,autogen_dif] Remove useless print
10a7c49 
Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[dif,pinmux] Add helper function to connect an MIO DT pin/pad.
ef9b4b8 
Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[dttool] Add support for pad description
105a738 
Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[dttool] Generate names of block instances
c3f1b0b 
This can be used for blocks where the numerical index as no meaning
but the top gave it a meaningful name, e.g. kDtIndexSramCtrlRetAon,
kDtIndexSramCtrlMain.

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[english_breakfast] Add stub for DT
7e6a572 
Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[flash_ctrl,testutils] Port to devicetables
5cec391 
Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[pinmux,testutils] Convert most of it to devicetables
43b0265 
Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[test_rom] Convert test_rom.c to devicetables
a80b976 
Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[test_rom] Generalize test_rom_start.S so it can handle multitop
bd8d64f 
Because it is written in assembly, we cannot use the C headers but
at least we can create some defines and handle english breakfast.

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[test_rom] Replace direct reference to top_earlgrey by //hw/top:top_lib
bf6c467 
Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[silicon_creator,drivers,ibex] Convert to devicetables
b3c538a 
Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[silicon_creator,drivers,uart] Port to devicetables
5ad3936 
Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[silicon_creator,drivers,spi_device] Port to devietables
39a6f66 
Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[silico_creator,lib,manifet] Generalize for multitop
ba5e285 
There are no DT structures to store the eflash size yet so use
ifdef for now.

Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[silicon_creator,rom,bootstrap] Convert to devicetables
29cc6d7 
Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[silicon_creator,flash_ctrl] Port to devicetables
7dd67be 
Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[otbn_randomness_test] Convert everything to DT except hintable clock
f2f2a12 
Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[aes_testutils] Port to DT
b54f6e5 
Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[aon_timer_testutils] Remove useless dependency on the top lib
78de407 
Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[entropy_testutils] Port to DT
f8cae9a 
Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[nv_counter_testutils] Port to DT
085a520 
Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
Reinstate all_files and remove files from opentitan_{ip,top}
599e662 
Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[top_earlgrey] Fix usage of legacy rules
eae3698 
Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[rand_testutils] Remove useless dependency on the top lib
5f04ddd 
Signed-off-by: Amaury Pouly <[email protected]>
@pamaury
[top_darjeeling] Move ast and sensor_ctrl to new rules
60f9b76 
Signed-off-by: Amaury Pouly <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rswarbrick rswarbrick Awaiting requested review from rswarbrick rswarbrick will be requested when the pull request is marked ready for review rswarbrick is a code owner

@msfschaffner msfschaffner Awaiting requested review from msfschaffner msfschaffner will be requested when the pull request is marked ready for review msfschaffner is a code owner

@vogelpi vogelpi Awaiting requested review from vogelpi vogelpi will be requested when the pull request is marked ready for review vogelpi is a code owner

@cfrantz cfrantz Awaiting requested review from cfrantz cfrantz will be requested when the pull request is marked ready for review cfrantz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pamaury