Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hw,tlul_adapter_sram,rtl] Expose reserved user bits #25373

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

Razer6
Copy link
Member

@Razer6 Razer6 commented Nov 25, 2024

The user bits on the reg-adapter are already exposed, meaning this adapter can set the bits. Create symmetry and expose the user bits as output, so that you can read them again.

On top_earlgrey, all usages are open outputs.

The user bits on the reg-adapter are already exposed, meaning
this adapter can set the bits. Create symmetry and expose the
user bits as output, so that you can read them again.

On top_earlgrey, all usages are open inputs.

Signed-off-by: Robert Schilling <[email protected]>
@Razer6 Razer6 requested a review from andreaskurth November 25, 2024 12:44
Copy link
Contributor

@andreaskurth andreaskurth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tlul_adapter_sram gets a new output port, which is left unconnected in existing instances, hence no functional change there. LGTM

@andreaskurth
Copy link
Contributor

CHANGE AUTHORIZED: hw/ip/hmac/rtl/hmac.sv
CHANGE AUTHORIZED: hw/ip/kmac/rtl/kmac.sv
CHANGE AUTHORIZED: hw/ip/kmac/rtl/kmac_staterd.sv
CHANGE AUTHORIZED: hw/ip/otbn/rtl/otbn.sv
CHANGE AUTHORIZED: hw/ip/otp_ctrl/rtl/otp_ctrl.sv
CHANGE AUTHORIZED: hw/ip/rom_ctrl/rtl/rom_ctrl.sv
CHANGE AUTHORIZED: hw/ip/spi_device/rtl/spi_device.sv
CHANGE AUTHORIZED: hw/ip/spi_host/rtl/spi_host_window.sv
CHANGE AUTHORIZED: hw/ip/sram_ctrl/rtl/sram_ctrl.sv
CHANGE AUTHORIZED: hw/ip/tlul/rtl/tlul_adapter_sram.sv
CHANGE AUTHORIZED: hw/ip/usbdev/rtl/usbdev.sv
CHANGE AUTHORIZED: hw/top_earlgrey/ip_autogen/flash_ctrl/rtl/flash_ctrl.sv

tlul_adapter_sram gets a new output port, which is left unconnected in existing instances, hence no functional change there.

@vogelpi
Copy link
Contributor

vogelpi commented Nov 28, 2024

CHANGE AUTHORIZED: hw/ip/hmac/rtl/hmac.sv
CHANGE AUTHORIZED: hw/ip/kmac/rtl/kmac.sv
CHANGE AUTHORIZED: hw/ip/kmac/rtl/kmac_staterd.sv
CHANGE AUTHORIZED: hw/ip/otbn/rtl/otbn.sv
CHANGE AUTHORIZED: hw/ip/otp_ctrl/rtl/otp_ctrl.sv
CHANGE AUTHORIZED: hw/ip/rom_ctrl/rtl/rom_ctrl.sv
CHANGE AUTHORIZED: hw/ip/spi_device/rtl/spi_device.sv
CHANGE AUTHORIZED: hw/ip/spi_host/rtl/spi_host_window.sv
CHANGE AUTHORIZED: hw/ip/sram_ctrl/rtl/sram_ctrl.sv
CHANGE AUTHORIZED: hw/ip/tlul/rtl/tlul_adapter_sram.sv
CHANGE AUTHORIZED: hw/ip/usbdev/rtl/usbdev.sv
CHANGE AUTHORIZED: hw/top_earlgrey/ip_autogen/flash_ctrl/rtl/flash_ctrl.sv

tlul_adapter_sram gets a new output port, which is left unconnected in existing instances, hence no functional change there.

@andreaskurth andreaskurth merged commit 92dd265 into lowRISC:master Nov 28, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants