Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[topgen] Support for external alert routing #25179

Merged
merged 3 commits into from
Nov 29, 2024
Merged

[topgen] Support for external alert routing #25179

merged 3 commits into from
Nov 29, 2024

Conversation

Razer6
Copy link
Member

@Razer6 Razer6 commented Nov 18, 2024 •
edited
Loading

This PR implements the external alert routing according to the RFC.

@Razer6 Razer6 force-pushed the external-alert-mappings branch 14 times, most recently from 9bcdc1f to 5f4d7ab Compare November 21, 2024 12:11
@Razer6 Razer6 marked this pull request as ready for review November 21, 2024 12:24
@Razer6 Razer6 requested a review from msfschaffner as a code owner November 21, 2024 12:24
@Razer6 Razer6 requested review from rswarbrick, andreaskurth and matutem and removed request for msfschaffner November 21, 2024 12:24
@Razer6 Razer6 force-pushed the external-alert-mappings branch from 5f4d7ab to cdaf37f Compare November 21, 2024 13:00
rswarbrick
rswarbrick reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@rswarbrick rswarbrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes on the first commit

hw/top_darjeeling/templates/toplevel.sv.tpl Outdated Show resolved Hide resolved
hw/top_darjeeling/templates/toplevel.sv.tpl Outdated Show resolved Hide resolved
util/topgen/merge.py Show resolved Hide resolved
hw/top_earlgrey/templates/toplevel.sv.tpl Outdated Show resolved Hide resolved
hw/top_earlgrey/templates/toplevel.sv.tpl Outdated Show resolved Hide resolved
util/topgen/merge.py Outdated Show resolved Hide resolved
util/topgen/merge.py Outdated Show resolved Hide resolved
util/topgen/merge.py Outdated Show resolved Hide resolved
util/topgen/merge.py Outdated Show resolved Hide resolved
util/topgen/merge.py Outdated Show resolved Hide resolved
andreaskurth
andreaskurth reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@andreaskurth andreaskurth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this work @Razer6. The underlying RFC is currently being reviewed, so I won't approve this PR yet. The changes in the PR seem to be aligned with the RFC, and in that sense they look good to me.

Please also add the RFC doc as Markdown to this PR. (You may want to wait with that until it's fully approved, though.)

@Razer6 Razer6 force-pushed the external-alert-mappings branch 3 times, most recently from c6757db to 559d853 Compare November 28, 2024 07:47
@Razer6
Copy link
Member Author

Razer6 commented Nov 28, 2024

@rswarbrick I think I addressed all your comments. Could you take another look?

@Razer6 Razer6 mentioned this pull request Nov 28, 2024
Open
@Razer6
Copy link
Member Author

Razer6 commented Nov 28, 2024

Please also add the RFC doc as Markdown to this PR. (You may want to wait with that until it's fully approved, though.)

@andreaskurth I added an issue to track the documentation of that.

@Razer6 Razer6 force-pushed the external-alert-mappings branch from 78a3be7 to 94f9fc5 Compare November 28, 2024 12:36
andreaskurth
andreaskurth approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@andreaskurth andreaskurth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx @Razer6 👍

@andreaskurth
Copy link
Contributor

@andreaskurth I added an issue to track the documentation of that.

For reference, that would be #25449

@andreaskurth
Copy link
Contributor

andreaskurth commented Nov 28, 2024 •
edited
Loading

CHANGE AUTHORIZED: hw/top_earlgrey/rtl/autogen/top_earlgrey.sv

Just whitespaces; no functional changes.

1 similar comment
@vogelpi
Copy link
Contributor

vogelpi commented Nov 28, 2024

CHANGE AUTHORIZED: hw/top_earlgrey/rtl/autogen/top_earlgrey.sv

Just whitespaces; no functional changes.

rswarbrick
rswarbrick reviewed Nov 28, 2024
View reviewed changes
util/topgen/merge.py Outdated Show resolved Hide resolved
util/topgen/merge.py Outdated Show resolved Hide resolved
rswarbrick
rswarbrick approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@rswarbrick rswarbrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks. One nitty comment about empty strings but it needn't really gate this going in.

@rswarbrick
Copy link
Contributor

CHANGE AUTHORIZED: hw/top_earlgrey/rtl/autogen/top_earlgrey.sv

As Andreas said, this is just a couple of blank lines: no functional change.

@Razer6 Razer6 force-pushed the external-alert-mappings branch from 94f9fc5 to c08759d Compare November 29, 2024 05:57
@Razer6 Razer6 force-pushed the external-alert-mappings branch from c08759d to 3c881a2 Compare November 29, 2024 06:43
@rswarbrick rswarbrick merged commit f4ecac6 into lowRISC:master Nov 29, 2024
32 of 37 checks passed
@Razer6 Razer6 deleted the external-alert-mappings branch November 29, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaskurth andreaskurth andreaskurth approved these changes

@rswarbrick rswarbrick rswarbrick approved these changes

@matutem matutem Awaiting requested review from matutem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Razer6 @andreaskurth @vogelpi @rswarbrick