[prim,fpv] Get rid of ASSERT_KNOWN in an FPV context #24454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rswarbrick
force-pushed
the
fpv-assert-known
branch
from
423c8a6 to
5cfc02b
Compare
Unknown signals aren't really supported by Jasper, which drops the assertion accordingly. Unfortunately, this shows up as a coverage hole (for a rather silly reason). Get rid of the assertion entirely if we are in this context (the signal is not X because the tool doesn't allow that to happen...) Signed-off-by: Rupert Swarbrick <[email protected]>
rswarbrick
force-pushed
the
fpv-assert-known
branch
from
5cfc02b to
86c52a6
Compare
alees24
approved these changes
Sep 19, 2024
|
CHANGE AUTHORIZED: hw/ip/prim/rtl/prim_assert.sv |
1 similar comment
|
CHANGE AUTHORIZED: hw/ip/prim/rtl/prim_assert.sv |
|
CHANGE AUTHORIZED: hw/ip/prim/rtl/prim_assert_standard_macros.svh |
1 similar comment
|
CHANGE AUTHORIZED: hw/ip/prim/rtl/prim_assert_standard_macros.svh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unknown signals aren't really supported by Jasper, which drops the assertion accordingly. Unfortunately, this shows up as a coverage hole (for a rather silly reason). Get rid of the assertion entirely if we are in this context (the signal is not X because the tool doesn't allow that to happen...)