[pentest] Add ROM FI tests #24296
Merged
[pentest] Add ROM FI tests #24296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nasahlpa
requested review from
pamaury,
vogelpi and
johannheyszl
and removed request for
a team and
pamaury
johannheyszl
approved these changes
Aug 22, 2024
This commit pulls over the ROM read digest FI test from the pentest branch of nasahlpa/opentitan that has been used for the penetration testing. Signed-off-by: Pascal Nasahl <[email protected]>
vogelpi
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Thanks Pascal, this is okay to get merged.
For the record: This is not production code but code that was used for penetration testing of Earlgrey ES. We should not implement changes to these tests that might have an impact on the test results. Instead the aim is to integrate the code more or less as is to be able to reproduce results and to have it ready for future penetration testing campaigns. The first PR of this series (#24294) has been reviewed by the SW team. The suggested style changes have also been integrated into this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit pulls over the ROM read digest FI test from the pentest branch of nasahlpa/opentitan that has been used for the penetration testing.