[rv_dm,dv] Use the "right enable" in *_jtag_dmi_debug_disabled_vseq #23981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rswarbrick
force-pushed
the
rv-dm-jtag-dmi-disabled-with-pinmux
branch
from
7180d03 to
2988669
Compare
vogelpi
approved these changes
Jul 12, 2024
|
Thanks. I'm going to force-push after rebasing because a bunch of CI(private) tests failed last time for unrelated IT issues. Assuming things look reasonable, I intend to merge this when they finish. (But it's an evening with children! If someone else gets here first, please feel free to hit the merge button! :-D) |
The existing logic wasn't quite correct: it only tried to start DMI (which uses pinmux) if debug was enabled. But we can sensibly talk to the debug module over DMI even when debug isn't enabled. Signed-off-by: Rupert Swarbrick <[email protected]>
The code here was a bit broken and I clearly hadn't previously understood the difference between "pinmux enabled" and "debug enabled". The *whole point* of this test is supposed to be that DMI transactions get blocked when pinmux is not enabled. After the changes here, we actually test that property! Signed-off-by: Rupert Swarbrick <[email protected]>
rswarbrick
force-pushed
the
rv-dm-jtag-dmi-disabled-with-pinmux
branch
from
2988669 to
1745c4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR looks reasonably large because it depends on #23799. Once that has been merged, there are two remaining commits:
The first commit is a tidyup in the base vseq (which I noticed when trying to fix the vseq for the second commit). The second commit is the main point of this PR. Its commit message is as follows:
[rv_dm,dv] Use the "right enable" in *_jtag_dmi_debug_disabled_vseq
The code here was a bit broken and I clearly hadn't previously
understood the difference between "pinmux enabled" and "debug
enabled".
The whole point of this test is supposed to be that DMI transactions
get blocked when pinmux is not enabled. After the changes here, we
actually test that property!