Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hw] Align HW IP block versions for Earlgrey-PROD #23969

Merged
merged 1 commit into from
Jul 12, 2024
Merged

[hw] Align HW IP block versions for Earlgrey-PROD #23969

merged 1 commit into from
Jul 12, 2024

Conversation

andreaskurth
Copy link
Contributor

The algorithm to determine the HW IP block version numbers is described in issue #22222. This resolves #22222.

@andreaskurth andreaskurth requested a review from vogelpi July 9, 2024 14:00
@andreaskurth andreaskurth self-assigned this Jul 9, 2024
@andreaskurth andreaskurth removed the request for review from msfschaffner July 9, 2024 14:00
andreaskurth
andreaskurth commented Jul 9, 2024
View reviewed changes
hw/ip/aes/data/aes.hjson Show resolved Hide resolved
hw/ip_templates/alert_handler/data/alert_handler.hjson.tpl Show resolved Hide resolved
hw/ip_templates/clkmgr/data/clkmgr.hjson.tpl
@@ -28,7 +28,7 @@
sw_checklist: "/sw/device/lib/dif/dif_clkmgr",
revisions: [
{
version: "1.0.0",
version: "1.0.1",
Copy link
Contributor Author

@andreaskurth andreaskurth Jul 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only clock buffers were inserted; no SW-visible functional changes as far as I have seen. CC @matutem

hw/ip/otbn/data/otbn.hjson Show resolved Hide resolved
hw/ip/pattgen/data/pattgen.hjson Show resolved Hide resolved
hw/ip/rv_dm/data/rv_dm.hjson Show resolved Hide resolved
hw/ip_templates/rv_plic/data/rv_plic.hjson.tpl Show resolved Hide resolved
hw/ip/spi_host/data/spi_host.hjson Show resolved Hide resolved
hw/ip/sram_ctrl/data/sram_ctrl.hjson Outdated Show resolved Hide resolved
hw/ip/usbdev/data/usbdev.hjson Show resolved Hide resolved
@vogelpi
Copy link
Contributor

vogelpi commented Jul 9, 2024

CHANGE AUTHORIZED: hw/ip/aes/data/aes.hjson
CHANGE AUTHORIZED: hw/ip/keymgr/data/keymgr.hjson
CHANGE AUTHORIZED: hw/ip/otbn/data/otbn.hjson
CHANGE AUTHORIZED: hw/ip/pattgen/data/pattgen.hjson
CHANGE AUTHORIZED: hw/ip/pinmux/data/pinmux.hjson.tpl
CHANGE AUTHORIZED: hw/ip/rom_ctrl/data/rom_ctrl.hjson
CHANGE AUTHORIZED: hw/ip/rv_core_ibex/data/rv_core_ibex.hjson
CHANGE AUTHORIZED: hw/ip/rv_dm/data/rv_dm.hjson
CHANGE AUTHORIZED: hw/ip/spi_host/data/spi_host.hjson
CHANGE AUTHORIZED: hw/ip/sram_ctrl/data/sram_ctrl.hjson
CHANGE AUTHORIZED: hw/ip/usbdev/data/usbdev.hjson
CHANGE AUTHORIZED: hw/ip_templates/alert_handler/data/alert_handler.hjson.tpl
CHANGE AUTHORIZED: hw/ip_templates/clkmgr/data/clkmgr.hjson.tpl
CHANGE AUTHORIZED: hw/ip_templates/pwrmgr/data/pwrmgr.hjson.tpl
CHANGE AUTHORIZED: hw/ip_templates/rv_plic/data/rv_plic.hjson.tpl
CHANGE AUTHORIZED: hw/top_earlgrey/ip_autogen/alert_handler/data/alert_handler.hjson
CHANGE AUTHORIZED: hw/top_earlgrey/ip_autogen/clkmgr/data/clkmgr.hjson
CHANGE AUTHORIZED: hw/top_earlgrey/ip_autogen/pwrmgr/data/pwrmgr.hjson
CHANGE AUTHORIZED: hw/top_earlgrey/ip_autogen/rv_plic/data/rv_plic.hjson

vogelpi
vogelpi approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@vogelpi vogelpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andreaskurth for preparing this and outlining the reasons. LGTM!

@andreaskurth
[hw] Align HW IP block versions for Earlgrey-PROD
1f1d890 
The algorithm to determine the HW IP block version numbers is described
in issue lowRISC#22222.  This resolves lowRISC#22222.

Signed-off-by: Andreas Kurth <[email protected]>
@andreaskurth andreaskurth force-pushed the align-hw-ip-block-versions branch from 3f4092b to 1f1d890 Compare July 10, 2024 07:06
@andreaskurth
Copy link
Contributor Author

CHANGE AUTHORIZED: hw/ip/aes/data/aes.hjson
CHANGE AUTHORIZED: hw/ip/keymgr/data/keymgr.hjson
CHANGE AUTHORIZED: hw/ip/otbn/data/otbn.hjson
CHANGE AUTHORIZED: hw/ip/pattgen/data/pattgen.hjson
CHANGE AUTHORIZED: hw/ip/pinmux/data/pinmux.hjson.tpl
CHANGE AUTHORIZED: hw/ip/rom_ctrl/data/rom_ctrl.hjson
CHANGE AUTHORIZED: hw/ip/rv_core_ibex/data/rv_core_ibex.hjson
CHANGE AUTHORIZED: hw/ip/rv_dm/data/rv_dm.hjson
CHANGE AUTHORIZED: hw/ip/spi_host/data/spi_host.hjson
CHANGE AUTHORIZED: hw/ip/sram_ctrl/data/sram_ctrl.hjson
CHANGE AUTHORIZED: hw/ip/usbdev/data/usbdev.hjson
CHANGE AUTHORIZED: hw/ip_templates/alert_handler/data/alert_handler.hjson.tpl
CHANGE AUTHORIZED: hw/ip_templates/clkmgr/data/clkmgr.hjson.tpl
CHANGE AUTHORIZED: hw/ip_templates/pwrmgr/data/pwrmgr.hjson.tpl
CHANGE AUTHORIZED: hw/ip_templates/rv_plic/data/rv_plic.hjson.tpl
CHANGE AUTHORIZED: hw/top_earlgrey/ip_autogen/alert_handler/data/alert_handler.hjson
CHANGE AUTHORIZED: hw/top_earlgrey/ip_autogen/clkmgr/data/clkmgr.hjson
CHANGE AUTHORIZED: hw/top_earlgrey/ip_autogen/pwrmgr/data/pwrmgr.hjson
CHANGE AUTHORIZED: hw/top_earlgrey/ip_autogen/rv_plic/data/rv_plic.hjson

rswarbrick
rswarbrick approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@rswarbrick rswarbrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone through the blocks and I think I agree with the deltas. Thanks for doing this!

GregAC
GregAC approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@GregAC GregAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gone through the blocks I'm tagged on and am happy with the changes.

ballifatih
ballifatih approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@ballifatih ballifatih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Keymgr, thanks @andreaskurth.

hw/ip/keymgr/data/keymgr.hjson Show resolved Hide resolved
@andreaskurth andreaskurth merged commit 5967df9 into lowRISC:master Jul 12, 2024
32 checks passed
@andreaskurth andreaskurth deleted the align-hw-ip-block-versions branch July 15, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alees24 alees24 alees24 left review comments

@rswarbrick rswarbrick rswarbrick approved these changes

@GregAC GregAC GregAC approved these changes

@ballifatih ballifatih ballifatih approved these changes

@vogelpi vogelpi vogelpi approved these changes

Assignees

@andreaskurth andreaskurth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update HW IP version numbers
6 participants
@andreaskurth @vogelpi @rswarbrick @GregAC @ballifatih @alees24