Skip to content

Commit

Permalink
[ci,nightly] Disable use of cached test results in nightly runs
Browse files Browse the repository at this point in the history
If FPGA test results can be cached through a remote cache, then we want
to ensure that all nightly test runs run without this caching (for the
test runs specifically, not the rest of the build), to allow us to be
able to spot flaky tests when they occur.

This commit achieves this by adding the `--cache_test_results=no`
argument to all invocations of `./bazelisk.sh test` in the nightly
Github Actions workflow.

Signed-off-by: Alex Jones <[email protected]>
  • Loading branch information
AlexJones0 committed Jan 10, 2025
1 parent 718fc07 commit 8428ef0
Showing 1 changed file with 31 additions and 6 deletions.
37 changes: 31 additions & 6 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,11 @@ jobs:
| grep -v examples \
| grep -v penetrationtests \
> "$bazel_tests"
./bazelisk.sh test --build_tests_only --test_tag_filters=-slow_test --target_pattern_file="$bazel_tests"
./bazelisk.sh test \
--build_tests_only \
--cache_test_results=no \
--test_tag_filters=-slow_test \
--target_pattern_file="$bazel_tests"
- name: Run tests after ROM_EXT boot stage
if: success() || failure()
Expand All @@ -72,7 +76,11 @@ jobs:
| grep -v examples \
| grep -v penetrationtests \
> "$bazel_tests"
./bazelisk.sh test --build_tests_only --test_tag_filters=-slow_test --target_pattern_file="$bazel_tests"
./bazelisk.sh test \
--build_tests_only \
--cache_test_results=no \
--test_tag_filters=-slow_test \
--target_pattern_file="$bazel_tests"
- name: Compute bucket destination
id: bucket_destination
Expand Down Expand Up @@ -128,7 +136,11 @@ jobs:
| grep -v examples \
| grep -v penetrationtests \
> "$bazel_tests"
./bazelisk.sh test --build_tests_only --test_tag_filters=-slow_test --target_pattern_file="$bazel_tests"
./bazelisk.sh test \
--build_tests_only \
--cache_test_results=no \
--test_tag_filters=-slow_test \
--target_pattern_file="$bazel_tests"
- name: Run tests after ROM_EXT boot stage
if: success() || failure()
Expand All @@ -139,7 +151,11 @@ jobs:
| grep -v examples \
| grep -v penetrationtests \
> "$bazel_tests"
./bazelisk.sh test --build_tests_only --test_tag_filters=-slow_test --target_pattern_file="$bazel_tests"
./bazelisk.sh test \
--build_tests_only \
--cache_test_results=no \
--test_tag_filters=-slow_test \
--target_pattern_file="$bazel_tests"
- name: Compute bucket destination
id: bucket_destination
Expand Down Expand Up @@ -198,7 +214,10 @@ jobs:
| grep -v penetrationtests \
> "$bazel_tests"
./bazelisk.sh test --build_tests_only --target_pattern_file="$bazel_tests"
./bazelisk.sh test \
--build_tests_only \
--cache_test_results=no \
--target_pattern_file="$bazel_tests"
- name: Compute bucket destination
id: bucket_destination
Expand Down Expand Up @@ -234,6 +253,7 @@ jobs:
--define bitstream=gcp_splice \
--test_tag_filters=-verilator,-dv,-broken \
--build_tests_only \
--cache_test_results=no \
--test_output=errors \
//sw/device/silicon_creator/rom/e2e/...
- name: Publish Bazel test results
Expand All @@ -256,7 +276,10 @@ jobs:
service_account_json: '${{ secrets.BAZEL_CACHE_CREDS }}'
- name: Run the tests
run: |
./bazelisk.sh test --test_tag_filters=nightly //sw/otbn/crypto/...
./bazelisk.sh test \
--cache_test_results=no \
--test_tag_filters=nightly \
//sw/otbn/crypto/...
- name: Publish Bazel test results
uses: ./.github/actions/publish-bazel-test-results
if: ${{ !cancelled() }}
Expand All @@ -282,6 +305,7 @@ jobs:
--define DISABLE_VERILATOR_BUILD=true \
--define bitstream=gcp_splice \
--build_tests_only \
--cache_test_results=no \
--test_output=errors \
--test_tag_filters="cw310_test_rom" \
$(./bazelisk.sh query 'attr("tags", "[\[ ]pmod[,\]]", tests(//...))')
Expand All @@ -292,6 +316,7 @@ jobs:
--define DISABLE_VERILATOR_BUILD=true \
--define bitstream=gcp_splice \
--build_tests_only \
--cache_test_results=no \
--test_output=errors \
--test_tag_filters=cw310_sival,-broken \
$(./bazelisk.sh query 'attr("tags", "[\[ ]pmod[,\]]", tests(//...))')
Expand Down

0 comments on commit 8428ef0

Please sign in to comment.