Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ibex_core] Fix assertion when SecureIbex is false #2251

Merged

Conversation

rswarbrick
Copy link
Contributor

This assertion wasn't quite correct if SecureIbex is false because it was checking for the magic IbexMuBiOn value instead of just looking at the bottom bit.

Fixes #2249.

This assertion wasn't quite correct if SecureIbex is false because it
was checking for the magic IbexMuBiOn value instead of just looking at
the bottom bit.

Fixes lowRISC#2249.
Copy link
Contributor

@vogelpi vogelpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rswarbrick rswarbrick added this pull request to the merge queue Jan 24, 2025
Merged via the queue into lowRISC:master with commit 7873956 Jan 24, 2025
11 checks passed
@rswarbrick rswarbrick deleted the no-fetch-assert-without-secure-ibex branch January 24, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ibex core assertion NoExecWhenFetchEnableNotOn not gated correctly.
2 participants