Lowrisc ip update #2145
Merged
Lowrisc ip update #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update code from upstream repository https://github.com/lowRISC/opentitan to revision e0c40265019aa0c74e6903d3b3a144c48a3815ec * [prim/lint] Fix long line lint error in prim_intr_hw (Alexander Williams) * [csr_seq_lib] Avoid slicing a queue (Rupert Swarbrick) * [dv] Make mem_model's compare_byte function less chatty (Rupert Swarbrick) * [doc,prim] Improve comments in prim_intr_hw (Harry Callahan) * [dvsim] Format FormalCfg code. (Miguel Osorio) * [dvsim] Add results_server dependency to FormalCfg (Miguel Osorio) * [prim_sha2] Add `hash_running_o` (Andreas Kurth) * [prim_sha2] Add `hash_continue_i` (Andreas Kurth) * [prim_sha2] Make digest writable from input while disabled (Andreas Kurth) * [dv,random_reset] Enhance handling of random resets (Guillermo Maturana) * [dv] Change implementation of special mubi access modes (Michael Schaffner) * [dv,cov_merge] Do serial coverage merge for vcs (Guillermo Maturana) * [dv/csr_utils] Change csr_peek to return the peeked value (Rupert Swarbrick) * [dv/csr_utils] Expand a documentation comment in csr_peek (Rupert Swarbrick) * [dv/csr_utils] Simplify HDL path checking in csr_peek (Rupert Swarbrick) * [dv/csr_utils] Use DV_CHECK to simplify code structure in csr_peek (Rupert Swarbrick) * [dv/csr_utils] Fix a seeming typo in csr_peek (Rupert Swarbrick) * [dv/csr_utils] Change `csr_peek` to function (Andreas Kurth) * [prim] Fix lint error in shadow register subreg primitive (Pirmin Vogel) * [otp_ctrl] Add second HW_CFG partition (Michael Schaffner) * [primgen] Fix parameters in a primgen template (Rupert Swarbrick) * [prim] Avoid unnecessary Impl parameter in prim_onehot_check (Rupert Swarbrick) * [hw,prim,sha2] Fix syntax error in waiver file (Robert Schilling) * [prim_sha2,rtl] prim_sha2 minor RTL and styling fixes (Ghada Dessouky) * [prim_sha2,rtl] Add RTL implementation + update core + lint waivers (Ghada Dessouky) * [otp_ctrl] Remove entropy_src chicken switches (Michael Schaffner) * [dv] Correct direct prediction of regwen (Michael Schaffner) * [clkmgr] Restructure division clock feedback (Michael Schaffner) * Revert "[edn] Move prim_edn_req out of prim" (Rupert Swarbrick) * [rtl, prim] Add 'commit' functionality to prim_count (Greg Chadwick) * [prim] Fix up 1r1w cores (Alexander Williams) * [prim] Add two-port memory ECC wrappers (Michael Schaffner) * [prim] Add two-port memory implementation (Michael Schaffner) * [prim] Make copies of dual port memory files (Michael Schaffner) * [otp_ctrl] Add support for multiple HW_CFG partitions (Michael Schaffner) * [otp_ctrl] Add option to disable integrity on a partition (Michael Schaffner) * [dv] Enhance RAL model with clearable mubi types (Michael Schaffner) Signed-off-by: Greg Chadwick <[email protected]>
The latest version of `prim_count` from OpenTitan introduces a `commit_i` input. To retain the behaviour of the previous `prim_count` this should be set to a constant 1. The `cnt_next_o` output has been renamed to `cnt_after_commit_o`.
|
Does it maybe make sense to wait until the CIP lib changes have been merged here lowRISC/opentitan#21226? Just because all of that stuff gets vendored. |
I don't think it matters, Ibex doesn't use those parts of the CIP lib (the icache testbench uses some of it, but it doesn't care about interrupts). |
marnovandermaas
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendors in the latest IP from opentitan.
prim_count has changed so a small tweak to
ibex_lockstepwas required. There are no functional differences.