Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tracer] Fix reporting of load/store data #2136

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

alees24
Copy link
Contributor

@alees24 alees24 commented Jan 31, 2024

Modify the tracer to use the appropriate read/write masks when logging load/store traffic from the Load Store Unit.
The logging code was using the wrong strobes when appending the loaded/stored values to the report as may be seen in the following snippet from a core trace:

         249402	    104397	000081cc	0062ae23	sw	x6,28(x5)	  x5:0x30470000  x6:0x03b9aca0 PA:0x3047001c store:0x03b9aca0 load:0x00000000
         249404	    104398	000081d0	4305	c.li	x6,1	  x6=0x00000001
         249442	    104417	000081d2	0062aa23	sw	x6,20(x5)	  x5:0x30470000  x6:0x00000001 PA:0x30470014 store:0x00000001 load:0x00000000
         249444	    104418	000081d6	30134537	lui	x10,0x30134	 x10=0x30134000
         249554	    104473	000081da	3d852283	lw	x5,984(x10)	 x10:0x30134000  x5=0x00000000 PA:0x301343d8 store:0x00000000

Specifically, when storing data the indicated 'store' value is correct but there is a spurious additional 'load: 0x00000000' indication, and when loading data, the trace instead shows 'store: 0x00000000'

@alees24 alees24 requested review from GregAC and rswarbrick January 31, 2024 10:14
Modify tracer to use the appropriate read/write masks when logging
load/store traffic from the Load Store Unit.

Signed-off-by: Adrian Lees <[email protected]>
@alees24 alees24 added this pull request to the merge queue Feb 17, 2024
Merged via the queue into lowRISC:master with commit 5a8a1a9 Feb 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants