[tracer] Fix reporting of load/store data #2136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the tracer to use the appropriate read/write masks when logging load/store traffic from the Load Store Unit.
The logging code was using the wrong strobes when appending the loaded/stored values to the report as may be seen in the following snippet from a core trace:
Specifically, when storing data the indicated 'store' value is correct but there is a spurious additional 'load: 0x00000000' indication, and when loading data, the trace instead shows 'store: 0x00000000'