Fix a couple of Verilator warnings #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rswarbrick
force-pushed
the
verilator-warnings
branch
2 times, most recently
from
1a67fbc to
45d60ca
Compare
rswarbrick
force-pushed
the
verilator-warnings
branch
2 times, most recently
from
cb7e723 to
c49f39b
Compare
The existing code wanted to open file_handle as a trace file if necessary and then use it on that clock cycle. So it (sensibly) used a blocking assignment. Verilator now warns about blocking assignments to globals in "sequential logic processes" (the always_ff that is driving everything). This is sort of easy to fix: just use an "always" block! This commit looks slightly more involved because I've changed things to pass the file handle to printbuffer_dumpline as an argument. It makes the state update (where we open the file handle) a little easier to follow.
rswarbrick
force-pushed
the
verilator-warnings
branch
from
c49f39b to
7aec140
Compare
marnovandermaas
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This waives/fixes a couple of warnings that appear with recent versions of Verilator. See the commit messages for details.
Fixes #2091.