Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: newarch build action #736

Merged
merged 1 commit into from
Jan 21, 2025
Merged

feat: newarch build action #736

merged 1 commit into from
Jan 21, 2025

Conversation

lovegaoshi
Copy link
Owner

@lovegaoshi lovegaoshi commented Jan 21, 2025

Summary by CodeRabbit

  • New Features

    • Added a new parallel build job for a different Android architecture in GitHub Actions workflow
    • Introduced a configuration modification script for Android application settings
  • Chores

    • Updated workflow to support building with new architecture configuration
    • Modified configuration files to enable new architectural settings

Copy link

vercel bot commented Jan 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
azusa-player-mobile ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 9:34pm

@lovegaoshi lovegaoshi merged commit 472975c into master Jan 21, 2025
6 of 7 checks passed
Copy link

coderabbitai bot commented Jan 21, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces a new GitHub Actions workflow job buildNewArch in the Android weekly workflow and a corresponding Python script newarch.py. The new job enables parallel building for a new architecture, with specific configuration modifications. The newarch.py script systematically updates various configuration files to support a new architectural variant of the Android application, including gradle properties, manifest, build configurations, and string resources.

Changes

File Change Summary
.github/workflows/android-weekly.yml Added buildNewArch job with parallel build configuration, similar to existing build job
scripts/newarch.py New script to modify configuration files:
- Update newArchEnabled to true
- Change android:authorities
- Modify applicationId with .new suffix
- Update application names in localized strings

Sequence Diagram

sequenceDiagram
    participant GHA as GitHub Actions
    participant Build as Build Job
    participant NewArch as New Arch Job
    
    GHA->>Build: Trigger standard build
    GHA->>NewArch: Trigger new arch build
    
    NewArch->>NewArch: Configure environment
    NewArch->>NewArch: Run newarch.py
    NewArch->>NewArch: Build APK
    NewArch-->>GHA: Generate app-newarch-arm64-v8a-release.apk
Loading

Poem

🐰 A Rabbit's Build Ballet 🏗️

In workflows where code takes flight,
New architectures shine so bright
With scripts that dance and configs sing
Our builds now have a fresher wing!
Hop, hop, hurrah for progress true! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fe413d2 and 40745f4.

📒 Files selected for processing (2)
  • .github/workflows/android-weekly.yml (1 hunks)
  • scripts/newarch.py (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant