Updates 20240101 #565
Merged
Updates 20240101 #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updates ObjectPool to assert range. - Documents FindFree precondition & asserts it. - Reorders Free member function to provide strong exception guarantee.
- Adds is-destroyed notion to Body. - Adds new WasDestroyed derived type of InvalidArgument. - Makes use of new notion & exception in world implementation. - Adds related unit tests.
- Makes use of empty Shape and empty Joint as is-destroyed info. - Switches remaining IsDestroyed functions from using FindFree to using boolean is-destroyed info from Joint & Shape. - Updates associated unit tests.
louis-langholtz
added
Enhancement
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description - What's this PR do?
Worldinterface.Impacts/Risks of These Changes?
Jointand emptyShapeobjects to mean is-destroyed.Related Issues