Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸŽ‰ Start user service #1

Merged
merged 5 commits into from
Dec 3, 2023
Merged

πŸŽ‰ Start user service #1

merged 5 commits into from
Dec 3, 2023

Conversation

nowgnas
Copy link
Member

@nowgnas nowgnas commented Nov 19, 2023 •
edited
Loading

κ°œμš”

  • add dockerfile
  • 초기 μ„ΈνŒ…

PR μœ ν˜•

μ–΄λ–€ λ³€κ²½ 사항이 μžˆλ‚˜μš”? βœ…

βœ… content
μƒˆλ‘œμš΄ κΈ°λŠ₯ μΆ”κ°€
버그 μˆ˜μ •
CSS λ“± μ‚¬μš©μž UI λ””μžμΈ λ³€κ²½
μ½”λ“œμ— 영ν–₯을 주지 μ•ŠλŠ” 변경사항(μ˜€νƒ€ μˆ˜μ •, νƒ­ μ‚¬μ΄μ¦ˆ λ³€κ²½, λ³€μˆ˜λͺ… λ³€κ²½)
μ½”λ“œ λ¦¬νŒ©ν† λ§
주석 μΆ”κ°€ 및 μˆ˜μ •
λ¬Έμ„œ μˆ˜μ •
ν…ŒμŠ€νŠΈ μΆ”κ°€, ν…ŒμŠ€νŠΈ λ¦¬νŒ©ν† λ§
βœ… λΉŒλ“œ λΆ€λΆ„ ν˜Ήμ€ νŒ¨ν‚€μ§€ λ§€λ‹ˆμ € μˆ˜μ •
파일 ν˜Ήμ€ 폴더λͺ… μˆ˜μ •
파일 ν˜Ήμ€ 폴더 μ‚­μ œ

슀크린 μƒ·

PR Checklist

PR이 λ‹€μŒ μš”κ΅¬ 사항을 μΆ©μ‘±ν•˜λŠ”μ§€ ν™•μΈν•˜μ„Έμš”.

  • localμ—μ„œ μ‹€ν–‰λ˜λŠ” 것을 확인 ν–ˆλ‚˜μš”?
  • λ³€κ²½ 사항에 λŒ€ν•΄ ν…ŒμŠ€νŠΈλ₯Ό ν†΅κ³Όν–ˆλ‚˜μš”?
  • 섀계와 κ΄€λ ¨λœ λ³€κ²½ 사항을 κ³΅μœ ν–ˆλ‚˜μš”? (api μŠ€νŽ™, entity λ“±)

@nowgnas nowgnas self-assigned this Nov 19, 2023
@nowgnas nowgnas requested a review from JIUNG9 November 19, 2023 05:25
@nowgnas nowgnas added the enhancement New feature or request label Nov 19, 2023
JIUNG9
JIUNG9 approved these changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@JIUNG9 JIUNG9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial project setting

@JIUNG9 JIUNG9 merged commit 93f883d into lotteon2:develop Dec 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JIUNG9 JIUNG9 JIUNG9 approved these changes

Assignees

@nowgnas nowgnas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nowgnas @JIUNG9