Jacoco 설정 및 카카오페이 결제준비 Service, Repository Test 생성 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binarywoo27
requested review from
nowgnas and
qwerty1434
and removed request for
nowgnas
qwerty1434
approved these changes
Nov 22, 2023
|
|
||
| @Service | ||
| public class PaymentService {} | ||
| @RequiredArgsConstructor | ||
| public class PaymentService { |
| * @param dto | ||
| * @return | ||
| */ | ||
| public KakaopayReadyResponseDto payReady(KakaopayReadyRequestDto dto) { |
There was a problem hiding this comment.
해당 메서드는 두 개의 역할을 가지고 있는 것 같습니다.
또한 트랜잭션 안에서 외부 호출이면서 오랜 시간이 소요될 가능성이 있는 restTemplate통신을 진행하는 게 좋지 못해 보입니다
There was a problem hiding this comment.
외부API 호출 로직을 분리하여 수정하였습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
Jacoco 설정 및 단건결제(카카오페이 결제준비) Service, Repository Test 생성
PR 유형
어떤 변경 사항이 있나요? ✅
스크린 샷
PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.