Update View Options to ASDK v6.3.4 (#57)

**What** - Updating the View Options app to ASDK 6.3.4 Signed-off-by: Mohsen Mirhoseini <[email protected]>
loopsocial · Jul 3, 2023 · 3b320ba · 3b320ba
1 parent 6937ead
commit 3b320ba
Show file tree

Hide file tree

Showing 13 changed files with 202 additions and 135 deletions.
diff --git a/.github/workflows/view_options.yml b/.github/workflows/view_options.yml
@@ -18,10 +18,10 @@ jobs:
     steps:
       - uses: actions/checkout@v3
 
-      - name: set up JDK 11
+      - name: set up JDK 17
         uses: actions/setup-java@v3
         with:
-          java-version: '11'
+          java-version: '17'
           distribution: 'temurin'
           cache: gradle
 

diff --git a/view_options/.idea/codeStyles/Project.xml b/view_options/.idea/codeStyles/Project.xml
diff --git a/view_options/app/build.gradle.kts b/view_options/app/build.gradle.kts
@@ -8,13 +8,13 @@ plugins {
 android {
     namespace = "com.firework.example.viewoptions"
 
-    compileSdk = 33
+    compileSdk = 34
 
     defaultConfig {
         applicationId = "com.firework.example.viewoptions"
 
         minSdk = 21
-        targetSdk = 33
+        targetSdk = 34
 
         versionCode = 1
         versionName = "1.0.0"
@@ -31,13 +31,13 @@ android {
     }
 
     compileOptions {
-        sourceCompatibility = JavaVersion.VERSION_1_8
-        targetCompatibility = JavaVersion.VERSION_1_8
+        sourceCompatibility = JavaVersion.VERSION_17
+        targetCompatibility = JavaVersion.VERSION_17
     }
 
     kotlinOptions {
         allWarningsAsErrors = true
-        jvmTarget = JavaVersion.VERSION_1_8.toString()
+        jvmTarget = JavaVersion.VERSION_17.toString()
     }
 
     lint {
@@ -69,7 +69,7 @@ dependencies {
     implementation("com.github.bumptech.glide:glide:4.13.2")
 
     // Firework SDK
-    val fireworkSdkVersion = "6.2.1"
+    val fireworkSdkVersion = "6.3.4"
     implementation("com.firework:sdk:$fireworkSdkVersion")
 
     // Glide (optional image loader)

diff --git a/view_options/app/src/main/java/com/firework/example/viewoptions/ExampleApplication.kt b/view_options/app/src/main/java/com/firework/example/viewoptions/ExampleApplication.kt
@@ -17,7 +17,7 @@ class ExampleApplication : Application() {
             .checksumRequired(false)
             .clientId(FW_CLIENT_ID) // Client OAUTH Id
             .userId("example app user ID") // User Id in your eco-system
-            .imageLoader(GlideImageLoaderFactory.createInstance()) // glide, picasso, or your implementation
+            .imageLoader(GlideImageLoaderFactory.createInstance(context = this)) // glide, picasso, or your implementation
             .muteOnLaunch(true)
             .build()
 

diff --git a/view_options/app/src/main/java/com/firework/example/viewoptions/MainActivity.kt b/view_options/app/src/main/java/com/firework/example/viewoptions/MainActivity.kt
@@ -115,7 +115,7 @@ class MainActivity : AppCompatActivity() {
                 playerMode(PlayerMode.FIT_MODE)
                 showFireworkLogo(true)
                 showMuteButton(true)
-                showPlayPauseButton(true)
+                showPlayPauseButtonInReplay(true)
                 showShareButton(true)
             }
 

diff --git a/view_options/app/src/main/res/layout/activity_main.xml b/view_options/app/src/main/res/layout/activity_main.xml
@@ -47,7 +47,7 @@
         app:fw_showFireworkLogo="true"
         app:fw_showMuteButton="true"
         app:fw_showPlayIcon="true"
-        app:fw_showPlayPauseButton="true"
+        app:fw_showPlayPauseButtonInReplay="true"
         app:fw_showShareButton="true"
         app:layout_constraintBottom_toTopOf="@id/details"
         app:layout_constraintTop_toTopOf="parent" />

diff --git a/view_options/app/src/main/res/values/styles.xml b/view_options/app/src/main/res/values/styles.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources xmlns:tools="http://schemas.android.com/tools">
 
-    <style name="FwCtaButtonStyle" parent="FwCtaButtonParentStyle" tools:ignore="UnusedResources">
+    <style name="FwCtaButtonStyle" parent="FwCtaButtonViewParentStyle" tools:ignore="UnusedResources">
         <item name="android:backgroundTint">@color/fw_cta_bg_bluelake</item>
         <item name="android:textColor">@color/white</item>
         <item name="android:fontFamily">sans-serif</item>

diff --git a/view_options/build.gradle.kts b/view_options/build.gradle.kts
@@ -1,7 +1,7 @@
 // Top-level build file where you can add configuration options common to all sub-projects/modules.
 plugins {
-    id("com.android.application") version "7.4.2" apply false
-    id("com.android.library") version "7.4.2" apply false
+    id("com.android.application") version "8.0.2" apply false
+    id("com.android.library") version "8.0.2" apply false
     id("org.jetbrains.kotlin.android") version "1.8.10" apply false
     id("org.jlleitschuh.gradle.ktlint") version "11.3.1" apply false
     id("io.gitlab.arturbosch.detekt") version "1.22.0" apply false

diff --git a/view_options/gradle.properties b/view_options/gradle.properties
@@ -20,4 +20,6 @@ kotlin.code.style=official
 # Enables namespacing of each library's R class so that its R class includes only the
 # resources declared in the library itself and none from the library's dependencies,
 # thereby reducing the size of the R class for that library
-android.nonTransitiveRClass=true
+android.nonTransitiveRClass=true
+android.defaults.buildfeatures.buildconfig=true
+android.nonFinalResIds=false
diff --git a/view_options/gradle/wrapper/gradle-wrapper.jar b/view_options/gradle/wrapper/gradle-wrapper.jar
diff --git a/view_options/gradle/wrapper/gradle-wrapper.properties b/view_options/gradle/wrapper/gradle-wrapper.properties
@@ -1,6 +1,7 @@
-#Tue Mar 07 12:31:58 CET 2023
 distributionBase=GRADLE_USER_HOME
-distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-bin.zip
 distributionPath=wrapper/dists
-zipStorePath=wrapper/dists
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.2-bin.zip
+networkTimeout=10000
+validateDistributionUrl=true
 zipStoreBase=GRADLE_USER_HOME
+zipStorePath=wrapper/dists