Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #193

Closed
wants to merge 1 commit into from
Closed

Update package.json #193

wants to merge 1 commit into from

Conversation

learnmews
Copy link

Description

upgrade mssql dependency to 4.2.1. mssql package has been updated to resolve an issue related to resource timeout error. Loopback connector is dependent on this package and can face similar issue.

Related issues

Checklist

No code changes. Only package.json update.

upgrade mssql dependency to 4.2.1. mssql package has been updated to resolve an issue related to resource timeout error. Loopback connector is dependent on this package and can face similar issue. 

tediousjs/node-mssql#610
tediousjs/node-mssql#683
@slnode
Copy link

slnode commented Aug 28, 2018

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@virkt25
Copy link
Contributor

virkt25 commented Aug 29, 2018

@slnode ok to test

@virkt25 virkt25 self-assigned this Aug 29, 2018
@dhmlau
Copy link
Member

dhmlau commented Sep 13, 2018

@learnmews , there is linting error in your commit message, because line 3 of your commit message is more than 72 characters. Could you please fix it? Here is the guideline: https://loopback.io/doc/en/contrib/git-commit-messages.html

There is also linting error on the extra semi-colon in the following 4 files. Would you like to fix it in this PR as well? Thanks!

14:18:39 /home/jenkins/workspace/nb/loopback-connector-mssql~master/7a48ad0e/lib/migration.js
14:18:39   188:6  error  Unnecessary semicolon  no-extra-semi
14:18:39 
14:18:39 /home/jenkins/workspace/nb/loopback-connector-mssql~master/7a48ad0e/lib/mssql.js
14:18:39   161:2  error  Unnecessary semicolon  no-extra-semi
14:18:39 
14:18:39 /home/jenkins/workspace/nb/loopback-connector-mssql~master/7a48ad0e/remove-regenerator.js
14:18:39   21:11  error  Unnecessary semicolon  no-extra-semi
14:18:39 
14:18:39 /home/jenkins/workspace/nb/loopback-connector-mssql~master/7a48ad0e/test/connection.js
14:18:39   54:2  error  Unnecessary semicolon  no-extra-semi
14:18:39 
14:18:39 ✖ 4 problems (4 errors, 0 warnings)
14:18:39   4 errors and 0 warnings potentially fixable with the `--fix` option.

@virkt25
Copy link
Contributor

virkt25 commented Sep 13, 2018

A quick note: If an app with the current version of the connector is redeployed (generate new package-lock.json if needed) -- the new version of node-mssql should be picked up by the connector automatically as we the dependency marked with a ^, meaning minor versions are picked up automatically.

@dhmlau
Copy link
Member

dhmlau commented Nov 2, 2018

@learnmews, as @virkt25 mentioned in the above comment, I don't think the change proposed in this PR is needed. With this reason, I'd like to close this PR. Thanks for your interest in improving our framework!

@dhmlau dhmlau closed this Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants