refactor: split packages #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
===========================================
+ Coverage 74.36% 88.35% +13.99%
===========================================
Files 18 21 +3
Lines 987 1065 +78
===========================================
+ Hits 734 941 +207
+ Misses 145 61 -84
+ Partials 108 63 -45 ☔ View full report in Codecov by Sentry. |
keroxp
changed the title
alfnets
reviewed
Jul 10, 2024
env/env.go
Outdated
| if noSvc != nil || noTd != nil { | ||
| return nil, nil, xerrors.Errorf("roll out context specified at '%s' but no 'service.json' or 'task-definition.json'", dir) | ||
| if noSvc != nil { | ||
| return nil, xerrors.Errorf("roll out context specified at '%s' but no 'service.json' or 'task-definition.json'", dir) |
There was a problem hiding this comment.
It would be better to update the error messages in the LoadServiceDefinition and LoadTaskDefinition functions to specify the corresponding missing files.
Suggested change
| return nil, xerrors.Errorf("roll out context specified at '%s' but no 'service.json' or 'task-definition.json'", dir) | |
| return nil, xerrors.Errorf("roll out context specified at '%s' but no 'service.json'", dir) |
env/env.go
Outdated
| _, noTd := os.Stat(tdPath) | ||
| var td ecs.RegisterTaskDefinitionInput | ||
| if noTd != nil { | ||
| return nil, xerrors.Errorf("roll out context specified at '%s' but no 'service.json' or 'task-definition.json'", dir) |
There was a problem hiding this comment.
Suggested change
| return nil, xerrors.Errorf("roll out context specified at '%s' but no 'service.json' or 'task-definition.json'", dir) | |
| return nil, xerrors.Errorf("roll out context specified at '%s' but no 'task-definition.json'", dir) |
Comment on lines
+45
to
+48
| } else if err := canaryTasks.Cleanup(ctx); err != nil { | ||
| log.Errorf("failed to cleanup canary tasks due to: %s", err) | ||
| lastErr = err | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes various changes across the package. Mainly, the most part of
cagewere split into sub packages for unit test convenience.task: codes for canary test, both ALB test and simple wait testtaskset: an abstraction of combined tasks for single servicerollout: a core logic part ofcage rollouttypes: common interfacesenv: environment variableslogos/di introduction
We are now using logos/di for dependency management.
Rewritten tests
Almost all tests have been rewritten, based on the policy below:
testpacgaestestpackage and failure tests with gomock forcagepackageNow, I chose the same package for unit test codes not
_test: to simulate failures that depends on internal stateOther changes
cagecommands skip loading task definition file if--taskDefinitionArnopt provided.--canaryIdleDurationchanged to 15 seconds.ElasticNetworkInterface