fix: add execute permission to upgraded cage binary

loilo-inc · May 30, 2024 · e3fdf36 · e3fdf36
1 parent 2d3c22b
commit e3fdf36
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/cli/cage/upgrade/upgrade.go b/cli/cage/upgrade/upgrade.go
@@ -220,5 +220,8 @@ func swapFiles(
 	if err := os.Remove(oldFilepath); err != nil {
 		return err
 	}
+	if err := os.Chmod(targetPath, 0755); err != nil {
+		return err
+	}
 	return nil
 }
diff --git a/cli/cage/upgrade/upgrade_test.go b/cli/cage/upgrade/upgrade_test.go
@@ -78,7 +78,7 @@ func TestUpgrade(t *testing.T) {
 		if err != nil {
 			t.Fatal(err)
 		}
-		err = os.WriteFile(tmpDir+"/cage", []byte(version+"\n"), 0644)
+		err = os.WriteFile(tmpDir+"/cage", []byte(version+"\n"), 0755)
 		if err != nil {
 			t.Fatal(err)
 		}
@@ -95,6 +95,8 @@ func TestUpgrade(t *testing.T) {
 		assert.True(t, os.IsNotExist(err))
 		_, err = os.Stat(tmpDir + "/cage.old")
 		assert.True(t, os.IsNotExist(err))
+		stat, _ := os.Stat(tmpDir + "/cage")
+		assert.Equal(t, 0755, int(stat.Mode().Perm()))
 	}
 
 	t.Run("basic", func(t *testing.T) {