Skip to content

Commit

Permalink
Removed obsolete key_path option
Browse files Browse the repository at this point in the history
  • Loading branch information
kaisecheng committed Sep 13, 2024
1 parent c29ff8d commit 4ab0755
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 20 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 5.0.0
- Removed obsolete `key_path` option

## 4.5.0
- Updated Google Cloud Storage client library, from `2.31.1` to `2.36.0` [#72](https://github.com/logstash-plugins/logstash-output-google_bigquery/pull/72)

Expand Down
19 changes: 1 addition & 18 deletions docs/index.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ This plugin supports the following configuration options plus the <<plugins-{typ
| <<plugins-{type}s-{plugin}-json_key_file>> |<<string,string>>|No
| <<plugins-{type}s-{plugin}-json_schema>> |<<hash,hash>>|No
| <<plugins-{type}s-{plugin}-key_password>> |<<string,string>>|__Deprecated__
| <<plugins-{type}s-{plugin}-key_path>> |<<string,string>>|*Obsolete*
| <<plugins-{type}s-{plugin}-project_id>> |<<string,string>>|Yes
| <<plugins-{type}s-{plugin}-service_account>> |<<string,string>>|__Deprecated__
| <<plugins-{type}s-{plugin}-skip_invalid_rows>> |<<boolean,boolean>>|No
Expand Down Expand Up @@ -225,7 +224,7 @@ mutate {
[id="plugins-{type}s-{plugin}-json_key_file"]
===== `json_key_file`

added[4.0.0, "Replaces <<plugins-{type}s-{plugin}-key_password>>, <<plugins-{type}s-{plugin}-key_path>> and <<plugins-{type}s-{plugin}-service_account>>."]
added[4.0.0, "Replaces <<plugins-{type}s-{plugin}-key_password>> and <<plugins-{type}s-{plugin}-service_account>>."]

* Value type is <<string,string>>
* Default value is `nil`
Expand Down Expand Up @@ -278,22 +277,6 @@ deprecated[4.0.0, Replaced by `json_key_file` or by using ADC. See <<plugins-{ty
* Value type is <<string,string>>


[id="plugins-{type}s-{plugin}-key_path"]
===== `key_path`

* Value type is <<string,string>>

**Obsolete:** The PKCS12 key file format is no longer supported.

Please use one of the following mechanisms:

* https://cloud.google.com/docs/authentication/production[Application Default Credentials (ADC)],
configured via environment variables on Compute Engine, Kubernetes Engine, App Engine, or
Cloud Functions.
* A JSON authentication key file. You can generate them in the console for the service account
like you did with the `.P12` file or with the following command:
`gcloud iam service-accounts keys create key.json --iam-account [email protected]`

[id="plugins-{type}s-{plugin}-project_id"]
===== `project_id`

Expand Down
1 change: 0 additions & 1 deletion lib/logstash/outputs/google_bigquery.rb
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,6 @@ class LogStash::Outputs::GoogleBigQuery < LogStash::Outputs::Base
# The following configuration options still exist to alert users that are using them
config :uploader_interval_secs, validate: :number, deprecated: 'No longer used.'
config :deleter_interval_secs, validate: :number, deprecated: 'No longer used.'
config :key_path, validate: :string, obsolete: 'Use json_key_file or ADC instead.'
config :key_password, validate: :string, deprecated: 'No longer needed with json_key_file or ADC.'
config :service_account, validate: :string, deprecated: 'No longer needed with json_key_file or ADC.'
config :temp_file_prefix, validate: :string, deprecated: 'No longer used.'
Expand Down
2 changes: 1 addition & 1 deletion version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
4.5.0
5.0.0

0 comments on commit 4ab0755

Please sign in to comment.