Remove empty event action params #464
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In event_action_params() clean params from nil and empty values - when using dynamic fields (like document_id => "%{[@metadata][document_id]}"), empty or nil values could be produced for document_id and parent fields (in es_bulk metadata part), which is not valid es_bulk metadata format, thus those values should be cleaned.
sxmichael
force-pushed
the
feature/clean_event_action_params
branch
from
ebeafcd to
ccb92b7
Compare
|
@untergeek @karmi any update? |
andrewvc
suggested changes
Oct 26, 2016
| expect(params).to include(:_id => "mytestid", :parent => "mytestparent") | ||
| end | ||
|
|
||
| it "should interpolate the requested id and parent values and leave them as is (sprintf behavior, not sure if correct one) when they missing" do |
There was a problem hiding this comment.
This behavior isn't great, but I don't know what else we can do here. I think this should be documented in the option docs.
| expect(params).to include(:_id => "%{myid}", :parent => "%{myparent}") | ||
| end | ||
|
|
||
| it "should interpolate the requested id and parent values and leave them as is (sprintf behavior, not sure if correct one) when they empty" do |
There was a problem hiding this comment.
This just repeats the previous test. I think you wanted to test that this should interpolate the requested id and parent values.
There was a problem hiding this comment.
Yeas, those are two identical tests, just to see the actual difference in behavior what happens when proposed remove_empty_action_params param set to true and to false.
|
Hey @andrewvc could this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In event_action_params() clean params from nil and empty values - when using dynamic fields (like document_id => "%{[@metadata][document_id]}"), empty or nil values could be produced for document_id and parent fields (in es_bulk metadata part), which is not valid es_bulk metadata format, thus those values should be cleaned.
I've added remove_empty_action_params configuration option to control this behavior (default is false).
Test is added as well.