Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to preserve dfDateTime object #910 #3210

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Changes to preserve dfDateTime object #910 #3210

merged 1 commit into from
Oct 8, 2020

Conversation

joachimmetz
Copy link
Member

@joachimmetz joachimmetz commented Aug 24, 2020 •
edited
Loading

Changes to preserve dfDateTime object #910

@joachimmetz joachimmetz added the blocked Work cannot progress until another issue is resolved label Aug 24, 2020
@joachimmetz joachimmetz changed the title Changes to preserve dfDateTime object Changes to preserve dfDateTime object #910 Aug 24, 2020
@joachimmetz joachimmetz mentioned this pull request Aug 24, 2020
Closed
20 tasks
@joachimmetz joachimmetz force-pushed the dfdatetime1 branch 2 times, most recently from c64921c to 7f8fc41 Compare September 21, 2020 15:57
@joachimmetz joachimmetz marked this pull request as ready for review September 21, 2020 15:58
@joachimmetz joachimmetz requested a review from rgayon September 21, 2020 15:58
@joachimmetz joachimmetz removed the blocked Work cannot progress until another issue is resolved label Sep 21, 2020
@joachimmetz joachimmetz added the blocked Work cannot progress until another issue is resolved label Sep 22, 2020
@codecov
Copy link

codecov bot commented Sep 23, 2020 •
edited
Loading

Codecov Report

Merging #3210 into master will decrease coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3210      +/-   ##
==========================================
- Coverage   86.13%   86.13%   -0.01%     
==========================================
  Files         383      383              
  Lines       32773    32823      +50     
==========================================
+ Hits        28228    28271      +43     
- Misses       4545     4552       +7
Impacted Files Coverage Δ
plaso/dependencies.py 0.00% <ø> (ø)
plaso/parsers/apt_history.py 91.40% <75.00%> (ø)
plaso/parsers/dpkg.py 89.83% <75.00%> (+0.17%) ⬆️
plaso/parsers/sophos_av.py 85.00% <75.00%> (+0.25%) ⬆️
plaso/parsers/winfirewall.py 94.84% <75.00%> (+0.05%) ⬆️
plaso/serializer/json_serializer.py 88.29% <83.72%> (-1.22%) ⬇️
plaso/containers/events.py 96.80% <100.00%> (+0.03%) ⬆️
plaso/containers/time_events.py 100.00% <100.00%> (ø)
plaso/parsers/iis.py 93.75% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4c94c1...228f125. Read the comment docs.

@joachimmetz joachimmetz removed the blocked Work cannot progress until another issue is resolved label Sep 26, 2020
@joachimmetz joachimmetz added this to the 2020 November release milestone Oct 5, 2020
@joachimmetz joachimmetz added the to merge Issue has been reviewed and can be merged when checks are complete label Oct 5, 2020
@joachimmetz joachimmetz assigned joachimmetz and unassigned rgayon Oct 5, 2020
@joachimmetz
Copy link
Member Author

To merge after next release

@joachimmetz joachimmetz added blocked Work cannot progress until another issue is resolved and removed blocked Work cannot progress until another issue is resolved to merge Issue has been reviewed and can be merged when checks are complete labels Oct 5, 2020
@joachimmetz joachimmetz merged commit 98e302b into log2timeline:master Oct 8, 2020
@joachimmetz joachimmetz deleted the dfdatetime1 branch October 8, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgayon rgayon rgayon approved these changes

Assignees

@joachimmetz joachimmetz

Labels
None yet
Projects
None yet
Milestone
2020 December release
Development

Successfully merging this pull request may close these issues.
2 participants
@joachimmetz @rgayon