fix: revert networkpolicy label selector #2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior, the label selector "k8s-app=kube-dns" in the NetworkPolicy template was changed to target the updated vcluster coredns pod name, vcluster-kube-dns. Enabling NetworkPolicy creates a NetworkPolicy in the host cluster. The NetworkPolicy intends to target the host's coredns pod which is still named kube-dns. The NetworkPolicy is additionally targeting the kube-system namespace. There is no pod that matches the "k8s-app=kube-dns" selector in the host's kube-system namespace. Now, the change to the NetworkPolicy's label selector has been reverted so that it properly selects for the host's kube-dns pod.
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
FabianKramm
approved these changes
Jan 13, 2025
loft-bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
Prior, the label selector "k8s-app=kube-dns" in the NetworkPolicy template was changed to target the updated vcluster coredns pod name, vcluster-kube-dns. Enabling NetworkPolicy creates a NetworkPolicy in the host cluster. The NetworkPolicy intends to target the host's coredns pod which is still named kube-dns. The NetworkPolicy is additionally targeting the kube-system namespace. There is no pod that matches the "k8s-app=kube-dns" selector in the host's kube-system namespace. Now, the change to the NetworkPolicy's label selector has been reverted so that it properly selects for the host's kube-dns pod. (cherry picked from commit 28c0b4c)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
rmweir
added a commit
that referenced
this pull request
Jan 13, 2025
Prior, the label selector "k8s-app=kube-dns" in the NetworkPolicy template was changed to target the updated vcluster coredns pod name, vcluster-kube-dns. Enabling NetworkPolicy creates a NetworkPolicy in the host cluster. The NetworkPolicy intends to target the host's coredns pod which is still named kube-dns. The NetworkPolicy is additionally targeting the kube-system namespace. There is no pod that matches the "k8s-app=kube-dns" selector in the host's kube-system namespace. Now, the change to the NetworkPolicy's label selector has been reverted so that it properly selects for the host's kube-dns pod. (cherry picked from commit 28c0b4c) Co-authored-by: Ricardo Weir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior, the label selector "k8s-app=kube-dns" in the NetworkPolicy template was changed to target the updated vcluster coredns pod name, vcluster-kube-dns. Enabling NetworkPolicy creates a NetworkPolicy in the host cluster. The NetworkPolicy intends to target the host's coredns pod which is still named kube-dns. The NetworkPolicy is additionally targeting the kube-system namespace. There is no pod that matches the "k8s-app=kube-dns" selector in the host's kube-system namespace. Now, the change to the NetworkPolicy's label selector has been reverted so that it properly selects for the host's kube-dns pod.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)Fixes ENG-5522
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster with etcd backing store did not have access to host's coredns pod.
What else do we need to know?