Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add workflow to clean up branch cache after pr merge #987

Merged
merged 1 commit into from
Feb 12, 2024
Merged

feat: add workflow to clean up branch cache after pr merge #987

merged 1 commit into from
Feb 12, 2024

Conversation

corneliusroemer
Copy link
Contributor

No description provided.

@corneliusroemer corneliusroemer marked this pull request as ready for review February 11, 2024 23:43
fengelniederhammer
fengelniederhammer approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@fengelniederhammer fengelniederhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think GitHub automatically deletes old cache entries when it runs out of space, but this probably also doesn't hurt.

@corneliusroemer
Copy link
Contributor Author

I think GitHub automatically deletes old cache entries when it runs out of space, but this probably also doesn't hurt.

It does indeed, but as we're now at that cache limit it doesn't harm to clean up as soon as we can when we know something won't be used - rather than letting it expire through LRU

@corneliusroemer corneliusroemer merged commit a7abbce into main Feb 12, 2024
8 checks passed
@corneliusroemer corneliusroemer deleted the clean-up-cache branch February 12, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengelniederhammer fengelniederhammer fengelniederhammer approved these changes

@theosanderson theosanderson Awaiting requested review from theosanderson

@chaoran-chen chaoran-chen Awaiting requested review from chaoran-chen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corneliusroemer @fengelniederhammer