Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

949 genes get pascal cased in edit page #968

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

bh-ethz
Copy link
Contributor

@bh-ethz bh-ethz commented Feb 9, 2024

resolves #949

Preview: https://949-genes-get-pascal-case.loculus.org/

PR Checklist

  • [ ] All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@corneliusroemer corneliusroemer added the preview Triggers a deployment to argocd label Feb 9, 2024
@bh-ethz bh-ethz marked this pull request as ready for review February 12, 2024 14:53
Copy link
Contributor

@corneliusroemer corneliusroemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fixed to me
image

Copy link
Contributor

@fengelniederhammer fengelniederhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengelniederhammer fengelniederhammer merged commit d53c9b5 into main Feb 13, 2024
12 checks passed
@fengelniederhammer fengelniederhammer deleted the 949-genes-get-pascal-cased--in-edit-page branch February 13, 2024 07:54
/>
))}
{editedMetadata.map((field) => {
field.key = sentenceCase(field.key);
Copy link
Contributor

@corneliusroemer corneliusroemer Mar 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addition of sentenceCase here might be the cause of #1261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Genes get Pascal cased (?) in edit page
3 participants