Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

943 redirect after successful submission #947

Merged
merged 1 commit into from
Feb 12, 2024
Merged

943 redirect after successful submission #947

merged 1 commit into from
Feb 12, 2024

Conversation

TobiasKampmann
Copy link
Contributor

@TobiasKampmann TobiasKampmann commented Feb 8, 2024 •
edited by corneliusroemer
Loading

resolves #943

http://943-redirect-after-succes.loculus.org/

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@TobiasKampmann TobiasKampmann force-pushed the 943-redirect-after-successful-submitting branch 2 times, most recently from 736cff9 to 6a966e5 Compare February 8, 2024 16:59
@TobiasKampmann TobiasKampmann added the preview Triggers a deployment to argocd label Feb 8, 2024
@TobiasKampmann TobiasKampmann force-pushed the 943-redirect-after-successful-submitting branch from 6a966e5 to 5592025 Compare February 8, 2024 17:26
@TobiasKampmann TobiasKampmann marked this pull request as ready for review February 8, 2024 17:26
corneliusroemer
corneliusroemer approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@corneliusroemer corneliusroemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!
2024-02-08 18 46 44

@corneliusroemer corneliusroemer changed the title 943 redirect after successful submitting 943 redirect after successful submission Feb 8, 2024
@corneliusroemer
Copy link
Contributor

What's blocking us from merging this? @theosanderson is your comment more of a suggestion for potential future improvements?

Or are we waiting for @fengelniederhammer's review?

fengelniederhammer
fengelniederhammer approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@fengelniederhammer fengelniederhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

website/src/components/ConfirmationDialog.tsx Outdated Show resolved Hide resolved
website/src/components/Submission/SubmissionForm.spec.tsx Show resolved Hide resolved
@TobiasKampmann TobiasKampmann force-pushed the 943-redirect-after-successful-submitting branch from 5592025 to fccab8d Compare February 12, 2024 15:22
@TobiasKampmann TobiasKampmann force-pushed the 943-redirect-after-successful-submitting branch from fccab8d to 1b9f83d Compare February 12, 2024 15:23
@TobiasKampmann TobiasKampmann merged commit dd95149 into main Feb 12, 2024
12 checks passed
@TobiasKampmann TobiasKampmann deleted the 943-redirect-after-successful-submitting branch February 12, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theosanderson theosanderson theosanderson left review comments

@fengelniederhammer fengelniederhammer fengelniederhammer approved these changes

@corneliusroemer corneliusroemer corneliusroemer approved these changes

Assignees
No one assigned
Labels
preview Triggers a deployment to argocd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redirect after (successful) submitting
4 participants
@TobiasKampmann @corneliusroemer @theosanderson @fengelniederhammer