Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deployment): Create liveness and readiness probes for lapis #2021

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

theosanderson
Copy link
Member

@theosanderson theosanderson commented May 26, 2024

Adds a kubernetes liveness and readiness probe for LAPIS. This is made possible by the fact that LAPIS can now start with zero seqs.

http://lapis-probe.loculus.org/

@theosanderson theosanderson added preview Triggers a deployment to argocd blocked Issue cannot be fixed until blocked resolved labels May 26, 2024
@corneliusroemer
Copy link
Contributor

corneliusroemer commented May 27, 2024

Interestingly, the preview works! What's this PR blocked on? E2E fails, is that because we currently still error on empty preprocessing inputs?

@theosanderson
Copy link
Member Author

Yes

@corneliusroemer
Copy link
Contributor

Thanks for confirming. There's progress on starting empty, should be available in the next few days:

@corneliusroemer corneliusroemer removed the preview Triggers a deployment to argocd label May 27, 2024
@theosanderson theosanderson marked this pull request as draft May 30, 2024 18:05
@theosanderson theosanderson removed the blocked Issue cannot be fixed until blocked resolved label Jun 19, 2024
@theosanderson theosanderson marked this pull request as ready for review June 19, 2024 20:51
@theosanderson theosanderson merged commit 7a9d50c into main Jun 19, 2024
9 checks passed
@theosanderson theosanderson deleted the lapis-probe branch June 19, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants