Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try running playwright in docker to avoid installation overhead #1883

Closed
wants to merge 3 commits into from
Closed

Try running playwright in docker to avoid installation overhead #1883

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79362c7
Try running playwright in docker to avoid installation overhead
corneliusroemer May 12, 2024
2e22369
try without telemetry
corneliusroemer May 12, 2024
78236dc
install yaml requests
corneliusroemer May 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 5 additions & 59 deletions .github/workflows/e2e-k3d.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,13 @@ jobs:
runs-on: ubuntu-latest-m
timeout-minutes: 30

container:
image: mcr.microsoft.com/playwright:v1.44.0-jammy

env:
ALL_BROWSERS: ${{ github.ref == 'refs/heads/main' && 'true' || 'false' }}

steps:
- name: Collect Workflow Telemetry
uses: catchpoint/workflow-telemetry-action@v2

- name: Checkout repository
uses: actions/checkout@v4

Expand All @@ -48,6 +48,7 @@ jobs:

- name: Create k3d cluster
run: |
pip install yaml requests
./deploy.py --verbose cluster

- name: Template with helm
Expand Down Expand Up @@ -75,62 +76,7 @@ jobs:
key: ${{ runner.os }}-node-${{ hashFiles('website/**/package-lock.json') }}

- name: Install dependencies
run: cd website && npm i

- name: Get Installed Playwright Version
id: playwright-version
run: cd website && echo "PLAYWRIGHT_VERSION=$(node -e "console.log(require('./package-lock.json').packages['node_modules/@playwright/test'].version)")" >> $GITHUB_ENV

- name: Cache Playwright Browsers
uses: actions/cache@v4
id: playwright-cache
with:
path: ~/.cache/ms-playwright
key: ${{ runner.os }}-playwright-${{ env.PLAYWRIGHT_VERSION }}

- name: Install Playwright Browsers and System Dependencies
run: cd website && npx playwright install --with-deps
if: steps.playwright-cache.outputs.cache-hit != 'true'

- name: Install only System Dependencies
run: cd website && npx playwright install-deps
if: steps.playwright-cache.outputs.cache-hit == 'true'

# Action misbehaved
# # Waits are identical to the update-argocd-metadata.yml file
# # Mirror changes to that file
# - name: Wait for Config Processor Docker Image
# uses: lewagon/[email protected]
# with:
# ref: ${{ github.sha }}
# check-name: Build config-processor Docker Image
# repo-token: ${{ secrets.GITHUB_TOKEN }}
# wait-interval: 2

# - name: Wait for Backend Docker Image
# uses: lewagon/[email protected]
# with:
# ref: ${{ github.sha }}
# check-name: Build Backend Docker Image
# repo-token: ${{ secrets.GITHUB_TOKEN }}
# wait-interval: 2

# - name: Wait for Website Docker Image
# uses: lewagon/[email protected]
# with:
# ref: ${{ github.sha }}
# check-name: Build Website Docker Image
# repo-token: ${{ secrets.GITHUB_TOKEN }}
# wait-interval: 2

# - name: Wait for Keycloakify Docker Image
# uses: lewagon/[email protected]
# with:
# ref: ${{ github.sha }}
# check-name: Build keycloakify Docker Image
# repo-token: ${{ secrets.GITHUB_TOKEN }}
# wait-interval: 2
# # End of wait block
run: cd website && npm ci

- name: Wait for the pods to be ready (timeout 480s)
run: ./.github/scripts/wait_for_pods_to_be_ready.py
Expand Down
Loading