Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(e2e): deflake, throw on console error, all-browser workflow dispatch, hydration bug workaround #1881

Merged
merged 18 commits into from
May 13, 2024
Merged

feat(e2e): deflake, throw on console error, all-browser workflow dispatch, hydration bug workaround #1881

merged 18 commits into from
May 13, 2024

Conversation

corneliusroemer
Copy link
Contributor

@corneliusroemer corneliusroemer commented May 12, 2024 •
edited
Loading

superficially resolves #1888

preview URL: https://robust-e2e.loculus.org

Summary

  • Superficially fix a hydration bug having impact on dummy-organism (when displayName is not set for grouped metadata search fields)
  • Deflake seqSet tests by disabling buttons when server side rendered (and adding TestID only on hydration)
  • Make E2E throw in the future when we have hydration errors: so we spot them soon and fix them
  • Allow running E2E tests in all browsers on request using workflow dispatch
  • Fix shas in docker image build workflows

@corneliusroemer corneliusroemer changed the title Clearer error messages Clearer E2E test error messages May 12, 2024
@corneliusroemer
Deflake seqset tests
40d8dbc
@corneliusroemer
Allow triggering of all browsers manually
e1f3182
@corneliusroemer
Use correct sha
e88c9f2
@corneliusroemer
Make seqset tests more robust
791deac
@corneliusroemer
Deflake search button test
ba55450
@corneliusroemer
fix #1887
1d16154 
This isn't a real fix. I don't know why the `field.label` value switched between SSR and client

Super weird. Suggests there is something else going on here.
@corneliusroemer
fix #1887
c42da19 
This isn't a real fix. I don't know why the `field.label` value switched between SSR and client

Super weird. Suggests there is something else going on here.
@corneliusroemer
Merge branch 'robust-e2e' of https://github.com/loculus-project/loculus…
e5071b8 
… into robust-e2e
@corneliusroemer corneliusroemer mentioned this pull request May 12, 2024
Closed
@corneliusroemer corneliusroemer added the preview Triggers a deployment to argocd label May 13, 2024
@corneliusroemer corneliusroemer added the review please PR waiting for final review label May 13, 2024
@corneliusroemer corneliusroemer marked this pull request as ready for review May 13, 2024 00:31
@corneliusroemer corneliusroemer changed the title Clearer E2E test error messages feat(e2e): deflake, throw on console error, all-browser workflow dispatch, hydration bug workaround May 13, 2024
chaoran-chen
chaoran-chen approved these changes May 13, 2024
View reviewed changes
website/tests/util/throwOnConsole.ts Outdated Show resolved Hide resolved
@corneliusroemer corneliusroemer merged commit 618ceff into main May 13, 2024
12 checks passed
@corneliusroemer corneliusroemer deleted the robust-e2e branch May 13, 2024 17:24
@corneliusroemer corneliusroemer mentioned this pull request May 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengelniederhammer fengelniederhammer fengelniederhammer left review comments

@chaoran-chen chaoran-chen chaoran-chen approved these changes

@theosanderson theosanderson Awaiting requested review from theosanderson

Assignees
No one assigned
Labels
preview Triggers a deployment to argocd review please PR waiting for final review
Projects
None yet
Milestone
No milestone
3 participants
@corneliusroemer @chaoran-chen @fengelniederhammer