Revert "chore(deps): bump gradle/actions from 3 to 321 (#1572)" #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 390c565. gradle/actions@v321 doesn't actually seem to exist.
Taepper
approved these changes
Apr 9, 2024
theosanderson
approved these changes
Apr 9, 2024
|
I looked into it: CI passed because v321 actually existed as a tag. But the devs must have revoked it as it was missing the dots in error. https://github.com/loculus-project/loculus/actions/runs/8605209435/job/23580981080 
I think the lesson is to check whether the version contains an obvious error: a jump from 3 to 321 makes no sense under semantic versioning - but I don't think this will happen frequently. |
|
Ah, interesting. They have version 3.2.1 and I assumed that they decided to encode it as 321. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #1572.
The checks in #1572 passed (maybe due to caches? I didn't check) but gradle/actions@v321 doesn't actually seem to exist. Sorry for merging!