Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customising search fields #1569

Merged
merged 10 commits into from
Apr 10, 2024
Merged

Allow customising search fields #1569

merged 10 commits into from
Apr 10, 2024

Conversation

theosanderson
Copy link
Member

@theosanderson theosanderson commented Apr 8, 2024

relates to #82, relates to #1503 - we can change the UX later to be more like #1503 if we want

preview URL: https://custom-search.loculus.org/ebola-zaire/search

Summary

Adds a modal with checkboxes to toggle visibility of search fields, with tests. Field initial visibility is controlled from helm values.

Screenshot

image

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@theosanderson theosanderson added the preview Triggers a deployment to argocd label Apr 8, 2024
@theosanderson theosanderson changed the title wip: Customise search Allow customising search fields Apr 10, 2024
Copy link
Member

@chaoran-chen chaoran-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@theosanderson theosanderson merged commit d2065d2 into main Apr 10, 2024
13 checks passed
@theosanderson theosanderson deleted the custom-search branch April 10, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants