Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): change paths of submission pages and re-use header #1564

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

chaoran-chen
Copy link
Member

@chaoran-chen chaoran-chen commented Apr 5, 2024

preview URL: https://submission-pages.loculus.org

Summary

I changed the paths to the submission-related pages. The submit, revise, review unreleased sequences, and view released sequences pages are now all under /submission/{groupId}/. The edit page is under /submission/edit/. The submit, revise, and view released sequences pages now also have the same group selector that was introduced in #1520.

This prepares for #1038.

Screenshots

image

image

PR Checklist

  • [ ] All necessary documentation has been adapted.
  • [ ] The implemented feature is covered by an appropriate test.

@chaoran-chen chaoran-chen added the preview Triggers a deployment to argocd label Apr 5, 2024
@chaoran-chen chaoran-chen marked this pull request as ready for review April 9, 2024 11:44
Copy link
Member

@theosanderson theosanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution!

@chaoran-chen chaoran-chen merged commit a27d203 into main Apr 9, 2024
13 checks passed
@chaoran-chen chaoran-chen deleted the submission-pages branch April 9, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants