Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(website): run eslint as defined in config #1540

Merged
merged 2 commits into from
Apr 2, 2024
Merged

chore(website): run eslint as defined in config #1540

merged 2 commits into from
Apr 2, 2024

Conversation

corneliusroemer
Copy link
Contributor

@corneliusroemer corneliusroemer commented Apr 2, 2024 •
edited
Loading

  • Run eslint as defined in config: this is what IDEs use and if we want to exclude tests from lint, we should make this explicit in config
  • Also introduce a convenience script npm run check that checks both format and types

@corneliusroemer corneliusroemer mentioned this pull request Apr 2, 2024
Merged
1 task
@corneliusroemer
chore(website): run eslint as defined in config
05b8d85 
Also introduce a convenience script `npm run check` that checks both format and types
@corneliusroemer
Merge main
f6be497
@corneliusroemer corneliusroemer merged commit 883c337 into main Apr 2, 2024
13 checks passed
@corneliusroemer corneliusroemer deleted the eslint-tests branch April 2, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaoran-chen chaoran-chen chaoran-chen approved these changes

@fengelniederhammer fengelniederhammer Awaiting requested review from fengelniederhammer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corneliusroemer @chaoran-chen