-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backend): reprocessing mechanism and processing pipeline versions #1506
Conversation
e9fe866
to
f2043b3
Compare
Please mind #1500. Maybe rebase this on top of that to prevent further merge conflicts? The benefit is simpler code. |
Can you describe what happens when the pipeline version increases:
|
Pipeline version is the entirety of the processing pipeline, not just the processing image but also its configuration in values.yaml In order to have multiple pipeline versions running for upgrading/testing, we need to adjust the k8s configuration to allow deployment of multiple pipelines, not just one as is the case at the moment. Is the pipeline version surfaced in Silo Export? I suppose it should be to make it verifiable by end users. |
Any clues about how to test this stuff? I suppose any tests could live entirely in the backend (unit) tests with mocked pipeline requests. On the other hand, it's not so bad to test manually: one just makes requests with a pipeline with version X, then more requests with version X+1 and sees what the backend does. Extensive debug/trace logs would be super useful there. |
07f8827
to
0849eb9
Compare
(Cornelius and I had a short call and clarified the questions.) |
@corneliusroemer, you're right, the error handling was wrong! Now, it should throw a 422. |
3a030df
to
ac9f492
Compare
ac9f492
to
ba6dd23
Compare
backend/src/main/kotlin/org/loculus/backend/service/submission/SubmissionDatabaseService.kt
Show resolved
Hide resolved
backend/src/main/kotlin/org/loculus/backend/service/submission/SubmissionDatabaseService.kt
Outdated
Show resolved
Hide resolved
.../main/kotlin/org/loculus/backend/service/submission/UseNewerProcessingPipelineVersionTask.kt
Outdated
Show resolved
Hide resolved
(looks really nice!) |
* Processing pipelines must now specify their version when they retrieve or submit sequences. * The data from a newer processing pipeline will be used when all sequences that had been successfully processed by the current pipeline were also successfully processed by the newer pipeline.
* Adjust nextclade pipeline with version param * Set pipeline version in values.yaml
* Adjust values.yaml and helm to allow multiple processing pipelines * fix config volume
23b0acb
to
db39ac2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Sorry, I didn't approve before because I thought there was still un-resolved stuff from Cornelius, but I was misunderstanding.
* Processing pipelines must now specify their version when they retrieve or submit sequences. * The data from a newer processing pipeline will be used when all sequences that had been successfully processed by the current pipeline were also successfully processed by the newer pipeline.
resolves #846
preview URL: https://reprocessing.loculus.org
Summary
PR Checklist