fix: stack depth limit exhausted when trying to release 9000 dummy sequences #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengelniederhammer
force-pushed
the
785-super-users
branch
from
e262dc1 to
94973f2
Compare
fengelniederhammer
force-pushed
the
982-stack-depth-limit-exhausted-when-trying-to-release-9000-dummy-sequences
branch
from
571d153 to
9a30f9d
Compare
chaoran-chen
approved these changes
Mar 27, 2024
One could also set the max_stack_depth in Postgres, but it's better if we don't rely on how the DB instance is configured.
fengelniederhammer
force-pushed
the
982-stack-depth-limit-exhausted-when-trying-to-release-9000-dummy-sequences
branch
from
9a30f9d to
060401b
Compare
fengelniederhammer
deleted the
982-stack-depth-limit-exhausted-when-trying-to-release-9000-dummy-sequences
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #982
preview URL: https://982-stack-depth-limit-exh.loculus.org/
Summary
One could also set the max_stack_depth in Postgres, but it's better if we don't rely on how the DB instance is configured.
This is a simple and robust solution.
Screenshot
PR Checklist
[ ] All necessary documentation has been adapted.[ ] The implemented feature is covered by an appropriate test.