Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): remove the AWAITING_APPROVAL_FOR_REVOCATION status #1482

Merged

Conversation

fengelniederhammer
Copy link
Contributor

@fengelniederhammer fengelniederhammer commented Mar 26, 2024

resolves #1456
also resolves #1444

preview URL: https://1456-remove-awaiting-appr.loculus.org/

Summary

Screenshot

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@fengelniederhammer fengelniederhammer added the preview Triggers a deployment to argocd label Mar 26, 2024
@fengelniederhammer fengelniederhammer force-pushed the 1456-remove-awaiting_approval_for_revocation-status branch from f127727 to 72a1671 Compare March 26, 2024 09:12
also do #1444 on the fly: log user errors on info, don't log the stack trace
@fengelniederhammer fengelniederhammer force-pushed the 1456-remove-awaiting_approval_for_revocation-status branch from 72a1671 to 4a0167f Compare March 26, 2024 12:31
Copy link
Member

@chaoran-chen chaoran-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@fengelniederhammer fengelniederhammer merged commit a14dcb7 into main Mar 27, 2024
13 checks passed
@fengelniederhammer fengelniederhammer deleted the 1456-remove-awaiting_approval_for_revocation-status branch March 27, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
2 participants