Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search page: use displayNames and allow column truncation #1461

Merged
merged 5 commits into from
Mar 28, 2024
Merged

Search page: use displayNames and allow column truncation #1461

merged 5 commits into from
Mar 28, 2024

Conversation

theosanderson
Copy link
Member

@theosanderson theosanderson commented Mar 23, 2024 •
edited
Loading

resolves #1413

preview URL: https://towards-truncation.loculus.org/ebola-zaire/search

Summary

Makes the search table column:

  • use displayNames where present
  • truncate long columns when configured to, and display tooltips with react-tooltip

Screenshot

image

@theosanderson theosanderson added the preview Triggers a deployment to argocd label Mar 23, 2024
@theosanderson theosanderson marked this pull request as draft March 23, 2024 23:58
@theosanderson theosanderson changed the title wip: further search page improvements Search page: use displayNames and allow column truncation Mar 27, 2024
@theosanderson theosanderson marked this pull request as ready for review March 27, 2024 13:17
@theosanderson theosanderson added this to the MVP (public) milestone Mar 28, 2024
corneliusroemer
corneliusroemer approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@corneliusroemer corneliusroemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing, thanks so much!

chaoran-chen
chaoran-chen approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@chaoran-chen chaoran-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for forgetting about this! Looks great, thanks!

@theosanderson theosanderson merged commit 256d177 into main Mar 28, 2024
14 checks passed
@theosanderson theosanderson deleted the towards_truncation branch March 28, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corneliusroemer corneliusroemer corneliusroemer approved these changes

@chaoran-chen chaoran-chen chaoran-chen approved these changes

@fengelniederhammer fengelniederhammer Awaiting requested review from fengelniederhammer

Assignees
No one assigned
Labels
preview Triggers a deployment to argocd
Projects
Planning
Status: Done
Milestone
MVP
Development

Successfully merging this pull request may close these issues.

Truncate long strings in browse table
3 participants
@theosanderson @chaoran-chen @corneliusroemer