Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add display name to metadata fields #1442

Merged
merged 9 commits into from
Mar 22, 2024
Merged

Add display name to metadata fields #1442

merged 9 commits into from
Mar 22, 2024

Conversation

theosanderson
Copy link
Member

@theosanderson theosanderson commented Mar 22, 2024

preview: https://displayName2.loculus.org

relates to #1424

Summary

  • Adds displayName to metadata fields, to avoid simple sentence/title casing
  • Adds a customDisplay option to metadata fields, currently used for:
    • displaying links to e.g. INSDC accessions
    • displaying the license terms history modal

I haven't tried to be comprehensive in adding displayNames (or links) for now, in part as we don't know what fields we want yet.

Screenshot

image

@theosanderson theosanderson added the preview Triggers a deployment to argocd label Mar 22, 2024
@corneliusroemer
Copy link
Contributor

corneliusroemer commented Mar 22, 2024

Something went wrong in the ingest pipeline - my guess (without having looked at logs) is that keycloak wasn't up when ingest tried to submit, which crashed ingest. But strange because it should have gotten restarted.

image

I think I know - ingest might have run on the old database and that got wiped. We should run ingest only once argocd sync is complete, somehow through a hook?

Submission went through at 17:47 UTC. But nothing ever got approved, possibly the group and database disappeared afterwards?

The database was set up at 17:47:50 - this explains it I think. Is it surprising that one container is started while the old one is still up? I suppose we should only start ingest when everything is ready and up.

Copy link
Contributor

@corneliusroemer corneliusroemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool stuff, thanks a lot!

@corneliusroemer
Copy link
Contributor

corneliusroemer commented Mar 22, 2024

E2E tests failed last time - and now it's green because it didn't run this time after you changed only the README:

They failed because cancelled - annoying that this counts as a failure rather than just not having completed...

I've triggered manually.
https://github.com/loculus-project/loculus/actions/runs/8394950880

@theosanderson theosanderson merged commit 262ecbe into main Mar 22, 2024
11 checks passed
@theosanderson theosanderson deleted the displayName2 branch March 22, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants