Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backend): prevent dataset updates with no changes #1427

Merged
merged 1 commit into from
Mar 21, 2024
Merged

fix(backend): prevent dataset updates with no changes #1427

merged 1 commit into from
Mar 21, 2024

Conversation

lukepereira
Copy link
Contributor

@lukepereira lukepereira commented Mar 21, 2024 •
edited
Loading

resolves #1351

preview URL: http://datasets-1351-update-vali.loculus.org/

Summary

  • Add backend validation on updateDataset to check that dataset name, description or records is changed
  • Add backend unit test for validation check

Screenshot

Screen Shot 2024-03-21 at 2 54 32 PM

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@lukepereira lukepereira added the preview Triggers a deployment to argocd label Mar 21, 2024
@lukepereira lukepereira force-pushed the datasets-1351-update-validation branch from 0f6904f to 581524a Compare March 21, 2024 19:01
@lukepereira lukepereira changed the title fix(website): prevent dataset updates with no changes fix(backend): prevent dataset updates with no changes Mar 21, 2024
corneliusroemer
corneliusroemer approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@corneliusroemer corneliusroemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, tested it and it works as expected

@lukepereira lukepereira merged commit f2bfffa into main Mar 21, 2024
13 checks passed
@lukepereira lukepereira deleted the datasets-1351-update-validation branch March 21, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corneliusroemer corneliusroemer corneliusroemer approved these changes

@chaoran-chen chaoran-chen Awaiting requested review from chaoran-chen

@theosanderson theosanderson Awaiting requested review from theosanderson

Assignees
No one assigned
Labels
preview Triggers a deployment to argocd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dataset: updating dataset with no changes to any values still creates a new version
2 participants
@lukepereira @corneliusroemer