Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(website): show NeedToLogin component on dataset landing page #1423

Merged
merged 1 commit into from
Mar 21, 2024
Merged

fix(website): show NeedToLogin component on dataset landing page #1423

merged 1 commit into from
Mar 21, 2024

Conversation

lukepereira
Copy link
Contributor

@lukepereira lukepereira commented Mar 21, 2024 •
edited by corneliusroemer
Loading

resolves #1404

preview URL: http://datasets-1404-login-redir.loculus.org/

Summary

  • show NeedToLogin component on dataset landing page instead of redircting to keycloak login page
  • remove dataset path from enforcedLoginRoutes middleware
  • (unrelated) add explanation text to citation plots on both dataset pages

Screenshot

image image

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@lukepereira lukepereira added the preview Triggers a deployment to argocd label Mar 21, 2024
@lukepereira lukepereira force-pushed the datasets-1404-login-redirect branch from 63c1596 to 4b07fe0 Compare March 21, 2024 16:57
@lukepereira lukepereira marked this pull request as ready for review March 21, 2024 16:57
corneliusroemer
corneliusroemer approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@corneliusroemer corneliusroemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@lukepereira lukepereira merged commit 962672f into main Mar 21, 2024
13 checks passed
@lukepereira lukepereira deleted the datasets-1404-login-redirect branch March 21, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corneliusroemer corneliusroemer corneliusroemer approved these changes

@chaoran-chen chaoran-chen Awaiting requested review from chaoran-chen

@theosanderson theosanderson Awaiting requested review from theosanderson

@fengelniederhammer fengelniederhammer Awaiting requested review from fengelniederhammer

Assignees
No one assigned
Labels
preview Triggers a deployment to argocd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Datasets: menu button should not redirect straight to login for not-logged-in users
2 participants
@lukepereira @corneliusroemer