444 sequence id generation #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiasKampmann
force-pushed
the
444-sequence-id-generation
branch
2 times, most recently
from
02338da to
da67d91
Compare
TobiasKampmann
force-pushed
the
444-sequence-id-generation
branch
from
da67d91 to
ec3746b
Compare
TobiasKampmann
force-pushed
the
444-sequence-id-generation
branch
4 times, most recently
from
654cf93 to
c0a899f
Compare
TobiasKampmann
changed the base branch from
main
to
1030-do-bulk-action-for-current-submissions
TobiasKampmann
force-pushed
the
1030-do-bulk-action-for-current-submissions
branch
from
462d7f3 to
d6c8e22
Compare
TobiasKampmann
force-pushed
the
444-sequence-id-generation
branch
from
c0a899f to
1c305f3
Compare
Base automatically changed from
1030-do-bulk-action-for-current-submissions
to
main
February 21, 2024 15:43
TobiasKampmann
force-pushed
the
444-sequence-id-generation
branch
from
3816e42 to
770e76c
Compare
TobiasKampmann
commented
Feb 21, 2024
TobiasKampmann
force-pushed
the
444-sequence-id-generation
branch
from
2777c32 to
6cc99ca
Compare
TobiasKampmann
commented
Feb 21, 2024
...end/src/test/kotlin/org/loculus/backend/service/submission/EmptyProcessedDataProviderTest.kt
Show resolved
Hide resolved
fengelniederhammer
requested changes
Feb 21, 2024
backend/src/main/kotlin/org/loculus/backend/service/submission/UploadDatabaseService.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/loculus/backend/service/submission/UploadDatabaseService.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/loculus/backend/service/GenerateAccessionFromNumberService.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/loculus/backend/service/GenerateAccessionFromNumberService.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/loculus/backend/service/GenerateAccessionFromNumberService.kt
Show resolved
Hide resolved
backend/src/main/kotlin/org/loculus/backend/service/GenerateAccessionFromNumberService.kt
Outdated
Show resolved
Hide resolved
...rc/test/kotlin/org/loculus/backend/controller/submission/ApproveProcessedDataEndpointTest.kt
Outdated
Show resolved
Hide resolved
backend/src/test/kotlin/org/loculus/backend/controller/submission/SubmitFiles.kt
Outdated
Show resolved
Hide resolved
...end/src/test/kotlin/org/loculus/backend/service/submission/EmptyProcessedDataProviderTest.kt
Show resolved
Hide resolved
TobiasKampmann
force-pushed
the
444-sequence-id-generation
branch
3 times, most recently
from
84ed763 to
116ce78
Compare
fengelniederhammer
approved these changes
Feb 22, 2024
backend/src/main/kotlin/org/loculus/backend/service/GenerateAccessionFromNumberService.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/loculus/backend/service/submission/UploadDatabaseService.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/loculus/backend/service/submission/UploadDatabaseService.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/loculus/backend/service/submission/UploadDatabaseService.kt
Outdated
Show resolved
Hide resolved
backend/src/test/kotlin/org/loculus/backend/service/GenerateAccessionFromNumberServiceTest.kt
Outdated
Show resolved
Hide resolved
backend/src/test/kotlin/org/loculus/backend/service/GenerateAccessionFromNumberServiceTest.kt
Outdated
Show resolved
Hide resolved
|
Follow up: |
TobiasKampmann
force-pushed
the
444-sequence-id-generation
branch
from
116ce78 to
e6be84c
Compare
TobiasKampmann
force-pushed
the
444-sequence-id-generation
branch
3 times, most recently
from
7489a9f to
6799111
Compare
TobiasKampmann
force-pushed
the
444-sequence-id-generation
branch
from
6799111 to
72da57f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #444
preview URL: https://444-sequence-id-generatio.loculus.org/
Summary
accessions will be generated from a unique sequence managed by postgres where the number is converted to a Base34 (numbers and capitalized chars omitting 'O' and 'I') string and padded with 0 to have at least 6 digits. A configurable prefix will be prepended and a checksum will be calculated and appended.
Screenshot
PR Checklist