Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "my sequences page" displaying released sequences #1037

Merged
merged 17 commits into from
Feb 20, 2024
Merged

Conversation

theosanderson
Copy link
Member

@theosanderson theosanderson commented Feb 19, 2024

resolves #1029

preview URL: http://mysequences.loculus.org

Summary

Creates a my sequences page that re-uses the search UI but with hidden filters to display only the group's sequences.

image

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@theosanderson theosanderson changed the title wip: Add a "my sequences page" wip: Add a "my sequences page" displaying released sequences Feb 19, 2024
@fengelniederhammer fengelniederhammer added the preview Triggers a deployment to argocd label Feb 19, 2024
Copy link
Contributor

@fengelniederhammer fengelniederhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check the code, but the page looks good. Definitely something we can take as a base 👍

@theosanderson theosanderson changed the title wip: Add a "my sequences page" displaying released sequences Add a "my sequences page" displaying released sequences Feb 19, 2024
@theosanderson theosanderson added this to the MVP (closed beta) milestone Feb 19, 2024
@theosanderson
Copy link
Member Author

The code should be ready now. There are aspects that aren't great - some of those come from Astro limitations, but I'm sure there's some bits we can work on.

Copy link
Contributor

@fengelniederhammer fengelniederhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

website/src/components/SearchPage/SearchPagination.tsx Outdated Show resolved Hide resolved
website/src/pages/[organism]/my_sequences.astro Outdated Show resolved Hide resolved
website/src/pages/[organism]/my_sequences/[group].astro Outdated Show resolved Hide resolved
website/src/pages/[organism]/my_sequences.astro Outdated Show resolved Hide resolved
website/src/pages/[organism]/my_sequences/[group].astro Outdated Show resolved Hide resolved
website/src/pages/[organism]/my_sequences/[group].astro Outdated Show resolved Hide resolved
website/src/routes.ts Outdated Show resolved Hide resolved
website/src/utils/search.ts Outdated Show resolved Hide resolved
@theosanderson theosanderson merged commit 6163414 into main Feb 20, 2024
12 checks passed
@theosanderson theosanderson deleted the mySequences branch February 20, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

mock-up released submissions
2 participants