Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1030 do bulk action for current submissions #1032

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

TobiasKampmann
Copy link
Contributor

@TobiasKampmann TobiasKampmann commented Feb 15, 2024

resolves #1030

preview URL: https://1030-do-bulk-action-for-c.loculus.org/

Summary

Extend backend and frontend so that bulk operations (approval and deletion) does work on all data not only on data on that page.

Screenshot

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@TobiasKampmann TobiasKampmann force-pushed the 1030-do-bulk-action-for-current-submissions branch 5 times, most recently from 08b61f3 to 1b04971 Compare February 19, 2024 13:05
@TobiasKampmann TobiasKampmann added the preview Triggers a deployment to argocd label Feb 19, 2024
@TobiasKampmann TobiasKampmann marked this pull request as ready for review February 19, 2024 13:10
@TobiasKampmann TobiasKampmann force-pushed the 1030-do-bulk-action-for-current-submissions branch 2 times, most recently from 1fca1c4 to 2b45050 Compare February 20, 2024 17:18
@TobiasKampmann TobiasKampmann force-pushed the 1030-do-bulk-action-for-current-submissions branch from 2b45050 to 402a20a Compare February 21, 2024 09:36
@TobiasKampmann TobiasKampmann force-pushed the 1030-do-bulk-action-for-current-submissions branch from 402a20a to 462d7f3 Compare February 21, 2024 12:24
@TobiasKampmann
Copy link
Contributor Author

TobiasKampmann commented Feb 21, 2024

@fengelniederhammer i simplified the deletion e2e a bit to reduce flakyness...

But actually that obscured a bug where the scope was not correctly set to ALL

 * adding scope to `get-sequences` `approve` and `delete` endpoint
 * remove browser-testrunner from testGroup and giving them all separate groups
@TobiasKampmann TobiasKampmann force-pushed the 1030-do-bulk-action-for-current-submissions branch from 462d7f3 to d6c8e22 Compare February 21, 2024 14:03
@TobiasKampmann TobiasKampmann merged commit cc8025d into main Feb 21, 2024
12 checks passed
@TobiasKampmann TobiasKampmann deleted the 1030-do-bulk-action-for-current-submissions branch February 21, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do bulk action for current submissions
2 participants