-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1030 do bulk action for current submissions #1032
Merged
TobiasKampmann
merged 1 commit into
main
from
1030-do-bulk-action-for-current-submissions
Feb 21, 2024
Merged
1030 do bulk action for current submissions #1032
TobiasKampmann
merged 1 commit into
main
from
1030-do-bulk-action-for-current-submissions
Feb 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiasKampmann
force-pushed
the
1030-do-bulk-action-for-current-submissions
branch
5 times, most recently
from
February 19, 2024 13:05
08b61f3
to
1b04971
Compare
fengelniederhammer
requested changes
Feb 19, 2024
backend/src/main/kotlin/org/loculus/backend/controller/SubmissionController.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/loculus/backend/controller/SubmissionController.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/loculus/backend/controller/SubmissionController.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/loculus/backend/controller/SubmissionController.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/loculus/backend/controller/SubmissionController.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/loculus/backend/service/submission/SequenceEntriesTable.kt
Outdated
Show resolved
Hide resolved
fengelniederhammer
requested changes
Feb 20, 2024
backend/src/main/kotlin/org/loculus/backend/api/SubmissionTypes.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/loculus/backend/api/SubmissionTypes.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/loculus/backend/api/SubmissionTypes.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/loculus/backend/controller/SubmissionController.kt
Show resolved
Hide resolved
backend/src/main/kotlin/org/loculus/backend/service/submission/SubmissionDatabaseService.kt
Outdated
Show resolved
Hide resolved
...rc/test/kotlin/org/loculus/backend/controller/submission/ApproveProcessedDataEndpointTest.kt
Outdated
Show resolved
Hide resolved
...end/src/test/kotlin/org/loculus/backend/controller/submission/DeleteSequencesEndpointTest.kt
Show resolved
Hide resolved
...end/src/test/kotlin/org/loculus/backend/controller/submission/DeleteSequencesEndpointTest.kt
Outdated
Show resolved
Hide resolved
...end/src/test/kotlin/org/loculus/backend/controller/submission/DeleteSequencesEndpointTest.kt
Show resolved
Hide resolved
...end/src/test/kotlin/org/loculus/backend/controller/submission/SubmissionConvenienceClient.kt
Outdated
Show resolved
Hide resolved
TobiasKampmann
force-pushed
the
1030-do-bulk-action-for-current-submissions
branch
2 times, most recently
from
February 20, 2024 17:18
1fca1c4
to
2b45050
Compare
backend/src/main/kotlin/org/loculus/backend/api/SubmissionTypes.kt
Outdated
Show resolved
Hide resolved
...end/src/test/kotlin/org/loculus/backend/controller/submission/DeleteSequencesEndpointTest.kt
Outdated
Show resolved
Hide resolved
...end/src/test/kotlin/org/loculus/backend/controller/submission/DeleteSequencesEndpointTest.kt
Outdated
Show resolved
Hide resolved
...end/src/test/kotlin/org/loculus/backend/controller/submission/SubmissionConvenienceClient.kt
Outdated
Show resolved
Hide resolved
...end/src/test/kotlin/org/loculus/backend/controller/submission/SubmissionConvenienceClient.kt
Outdated
Show resolved
Hide resolved
TobiasKampmann
force-pushed
the
1030-do-bulk-action-for-current-submissions
branch
from
February 21, 2024 09:36
2b45050
to
402a20a
Compare
TobiasKampmann
force-pushed
the
1030-do-bulk-action-for-current-submissions
branch
from
February 21, 2024 12:24
402a20a
to
462d7f3
Compare
@fengelniederhammer i simplified the deletion e2e a bit to reduce flakyness... But actually that obscured a bug where the scope was not correctly set to |
* adding scope to `get-sequences` `approve` and `delete` endpoint * remove browser-testrunner from testGroup and giving them all separate groups
TobiasKampmann
force-pushed
the
1030-do-bulk-action-for-current-submissions
branch
from
February 21, 2024 14:03
462d7f3
to
d6c8e22
Compare
fengelniederhammer
approved these changes
Feb 21, 2024
TobiasKampmann
deleted the
1030-do-bulk-action-for-current-submissions
branch
February 21, 2024 15:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1030
preview URL: https://1030-do-bulk-action-for-c.loculus.org/
Summary
Extend backend and frontend so that bulk operations (approval and deletion) does work on all data not only on data on that page.
Screenshot
PR Checklist