deployment: add 1 hour limit for SILO import #1022
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Got some suggestions for how to do this - essentially rewriting your PR but I thought I don't open a new one but just tag onto yours ;) |
|
Preview deployment says it's out of sync, strange I've deleted the cronjob - but somehow it's not enough to make it synced This is the diff: |
|
Sorry only just seen any of these - thanks for all the thoughts and spotting the bug! Closing in favour of #1025 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1020 (doesn't necessarily necessarily fully resolve it, but mentioning this to ensure the link is made)
preview URL: https://limit-silo-import.loculus.org/
Summary
Limits each run of the SILO import pipeline to 1 hour, configurable, in case it stalls for some reason.