Enable preprocessing in helm for codespaces #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusroemer
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
In general I think the ability to get data into the DB is more important than the ability to run the E2E tests from the codespace so I think this makes sense as the lesser of two evils. In due course we can make multiple codespace configs.
As you're the only user right now I don't see why one shouldn't enable preprocessing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables preprocessing in helm for codespaces. When I included this is in a PR before @fengelniederhammer sensibly pointed out it would break the ability to run the e2e tests in codespaces - but I'm the only person using the codespaces atm as far as I know and I personally only run these tests from CI.
I have tried running
./deploy.py helm uninstalland then redeploying with processing enabled after startup, but this yields an error message about the groups table already existing or something. In general I think the ability to get data into the DB is more important than the ability to run the E2E tests from the codespace so I think this makes sense as the lesser of two evils. In due course we can make multiple codespace configs.