-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix metadata types #1013
Fix metadata types #1013
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did this manifest pre-PR? Was anything broken? What's possible now that wasn't before?
We should probably rework this at some point to show less frightening errors to the users:
|
Thanks so much @fengelniederhammer - I had no clue what this PR was fixing and your summary makes it very easy to understand! |
Do you want to test in a preview? 😜 I didn't realize this isn't actually merging into main, so ignore - it can be tested in the main PR |
I found it while reviewing the PR of the base branch of this - so I didn't want to clutter that. I'll wait until that is merged and merge this to main then. |
5646075
to
e725672
Compare
c4ce8e3
to
76e4a9a
Compare
unprocessed metadata is always Map<String, String>, processed metadata fields can be null
76e4a9a
to
846065d
Compare
PR Checklist
[ ] All necessary documentation has been adapted.